Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging [v2]

2024-01-02 Thread Stefan Karlsson
On Tue, 12 Dec 2023 09:01:08 GMT, Stefan Karlsson wrote: >> There is some logging printed when tests spawns processes. This logging is >> triggered from calls to `OutputAnalyzer`, when it delegates calls to >> `LazyOutputBuffer`. >> >> If we write code like this: >> >> ProcessBuilder pb =

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging [v3]

2024-01-02 Thread Stefan Karlsson
> There is some logging printed when tests spawns processes. This logging is > triggered from calls to `OutputAnalyzer`, when it delegates calls to > `LazyOutputBuffer`. > > If we write code like this: > > ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...); > OutputAnalyzer

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging [v2]

2023-12-14 Thread Jaikiran Pai
On Tue, 12 Dec 2023 09:01:08 GMT, Stefan Karlsson wrote: >> There is some logging printed when tests spawns processes. This logging is >> triggered from calls to `OutputAnalyzer`, when it delegates calls to >> `LazyOutputBuffer`. >> >> If we write code like this: >> >> ProcessBuilder pb =

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging

2023-12-12 Thread David Holmes
On Tue, 12 Dec 2023 08:57:08 GMT, Stefan Karlsson wrote: > Do you agree that it would be OK to remove the test? Sure that's fine. - PR Comment: https://git.openjdk.org/jdk/pull/17052#issuecomment-1851644385

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging [v2]

2023-12-12 Thread Stefan Karlsson
> There is some logging printed when tests spawns processes. This logging is > triggered from calls to `OutputAnalyzer`, when it delegates calls to > `LazyOutputBuffer`. > > If we write code like this: > > ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...); > OutputAnalyzer

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging [v2]

2023-12-12 Thread Stefan Karlsson
On Tue, 12 Dec 2023 07:43:31 GMT, David Holmes wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Typo > > test/lib/jdk/test/lib/process/OutputAnalyzer.java line 111: > >> 109: /** >> 110: * Delegate

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging

2023-12-12 Thread Stefan Karlsson
On Mon, 11 Dec 2023 11:16:05 GMT, Stefan Karlsson wrote: > There is some logging printed when tests spawns processes. This logging is > triggered from calls to `OutputAnalyzer`, when it delegates calls to > `LazyOutputBuffer`. > > If we write code like this: > > ProcessBuilder pb =

Re: RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging

2023-12-11 Thread David Holmes
On Mon, 11 Dec 2023 11:16:05 GMT, Stefan Karlsson wrote: > There is some logging printed when tests spawns processes. This logging is > triggered from calls to `OutputAnalyzer`, when it delegates calls to > `LazyOutputBuffer`. > > If we write code like this: > > ProcessBuilder pb =

RFR: 8321718: ProcessTools.executeProcess calls waitFor before logging

2023-12-11 Thread Stefan Karlsson
There is some logging printed when tests spawns processes. This logging is triggered from calls to `OutputAnalyzer`, when it delegates calls to `LazyOutputBuffer`. If we write code like this: ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(...); OutputAnalyzer output = new