On Wed, 10 Jan 2024 18:29:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Wed, 10 Jan 2024 17:37:11 GMT, Lance Andersen wrote:
> Extra credit to convert this from testng to a junit test but not a must
Challenge accepted, see 885871f for the conversion to JUnit 5.
-
PR Comment: https://git.openjdk.org/jdk/pull/17170#issuecomment-1885395478
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and 'sticky' bits. These are unrelated to permissions and should not
On Wed, 10 Jan 2024 17:37:11 GMT, Lance Andersen wrote:
> Thank you for the PR. Overall it looks good a few couple nit comments.
Thanks Lance, see e4a505fa073874824f247c20b76c3531a068ee32 for the latest
update following your review.
> test/jdk/jdk/nio/zipfs/TestPosix.java line 761:
>
>> 759:
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and 'sticky' bits. These are unrelated to permissions and should not
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Tue, 9 Jan 2024 22:08:20 GMT, Christoph Langer wrote:
>> Eirik Bjørsnøs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
On Tue, 9 Jan 2024 10:22:40 GMT, Eirik Bjørsnøs wrote:
>> This PR suggests that `Files.setPosixPermissions`as implemented by
>> `ZipFileSystem` should preserve the leading seven bits of the 'external file
>> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
>> and
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and 'sticky' bits. These are unrelated to permissions and should not
On Wed, 20 Dec 2023 18:51:08 GMT, Eirik Bjørsnøs wrote:
> This PR suggests that `Files.setPosixPermissions`as implemented by
> `ZipFileSystem` should preserve the leading seven bits of the 'external file
> attributes' field. These bits contain the 'file type', 'setuid', 'setgid',
> and
This PR suggests that `Files.setPosixPermissions`as implemented by
`ZipFileSystem` should preserve the leading seven bits of the 'external file
attributes' field. These bits contain the 'file type', 'setuid', 'setgid', and
'sticky' bits. These are unrelated to permissions and should not be
13 matches
Mail list logo
