On Sun, 28 Jan 2024 00:57:24 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Add test for zero-out
>
> test/jdk/java/foreign/TestScope.java line 150:
>
>> 148: }
>>
On Fri, 12 Jan 2024 14:35:01 GMT, Per Minborg wrote:
>> This PR proposes to add a clarification that an `Arena` always returns
>> zeroed-out segments for `Arena::allocate` methods.
>>
>> Note that other overloaded methods refer to the abstract `Arena::allocate`
>> method via implementation
On Tue, 16 Jan 2024 08:47:47 GMT, Per Minborg wrote:
>> 8323159: Consider adding some text re. memory zeroing in Arena::allocate
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing comma in TestScope.java
Marked as
On Tue, 16 Jan 2024 08:47:47 GMT, Per Minborg wrote:
>> 8323159: Consider adding some text re. memory zeroing in Arena::allocate
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing comma in TestScope.java
Looks
On Mon, 15 Jan 2024 16:23:34 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing comma in TestScope.java
>
> test/jdk/java/foreign/TestScope.java line 2:
>
>> 1: /*
>> 2: * Copyright (c)
> 8323159: Consider adding some text re. memory zeroing in Arena::allocate
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add missing comma in TestScope.java
-
Changes:
- all:
On Mon, 15 Jan 2024 16:14:15 GMT, Per Minborg wrote:
> 8323159: Consider adding some text re. memory zeroing in Arena::allocate
test/jdk/java/foreign/TestScope.java line 2:
> 1: /*
> 2: * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights
> reserved.
Can you hold off on this
8323159: Consider adding some text re. memory zeroing in Arena::allocate
-
Commit messages:
- Backport f5b757ced6b672010ea10575d644d3f9d1728923
Changes: https://git.openjdk.org/jdk22/pull/77/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22=77=00
Issue:
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
Per Minborg has updated the pull request incrementally
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
Per Minborg has updated the pull request incrementally
On Fri, 12 Jan 2024 13:06:39 GMT, Per Minborg wrote:
>> This PR proposes to add a clarification that an `Arena` always returns
>> zeroed-out segments for `Arena::allocate` methods.
>>
>> Note that other overloaded methods refer to the abstract `Arena::allocate`
>> method via implementation
On Fri, 12 Jan 2024 13:06:39 GMT, Per Minborg wrote:
>> This PR proposes to add a clarification that an `Arena` always returns
>> zeroed-out segments for `Arena::allocate` methods.
>>
>> Note that other overloaded methods refer to the abstract `Arena::allocate`
>> method via implementation
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
Per Minborg has updated the pull request incrementally
On Thu, 11 Jan 2024 07:59:37 GMT, Per Minborg wrote:
>> This PR proposes to add a clarification that an `Arena` always returns
>> zeroed-out segments for `Arena::allocate` methods.
>>
>> Note that other overloaded methods refer to the abstract `Arena::allocate`
>> method via implementation
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
Per Minborg has updated the pull request incrementally
On Wed, 10 Jan 2024 14:29:37 GMT, Jorn Vernee wrote:
>> The choice here is: if we allow non-zeroing implementation, implementors of
>> Arena have more flexibility, but clients have less guarantees (how does a
>> client know if what they get back is zeroed?)
>
>> (how does a client know if what
On Wed, 10 Jan 2024 14:21:15 GMT, Maurizio Cimadamore
wrote:
> (how does a client know if what they get back is zeroed?)
It seems similar to e.g. a HashMap vs. LinkedHashMap with regards to ordering.
The creator of the Arena would decide the zeroing strategy.
-
PR Review
On Wed, 10 Jan 2024 14:12:02 GMT, Jorn Vernee wrote:
>> This PR proposes to add a clarification that an `Arena` always returns
>> zeroed-out segments for `Arena::allocate` methods.
>>
>> Note that other overloaded methods refer to the abstract `Arena::allocate`
>> method via implementation
On Wed, 10 Jan 2024 14:19:29 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/Arena.java line 269:
>>
>>> 267: * @implSpec
>>> 268: * Implementations of this method must return a native,
>>> zero-initialized segment
>>> 269: * featuring the
On Mon, 8 Jan 2024 16:16:50 GMT, Per Minborg wrote:
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
On Mon, 8 Jan 2024 16:16:50 GMT, Per Minborg wrote:
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
This PR proposes to add a clarification that an `Arena` always returns
zeroed-out segments for `Arena::allocate` methods.
Note that other overloaded methods refer to the abstract `Arena::allocate`
method via implementation notes.
-
Commit messages:
- Add in @implSpec that
22 matches
Mail list logo
