Re: [jdk22] RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Iris Clark
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote: > Backport to fix the regression introduced in JDK 22. Verified changes same as those in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817021441

Re: [jdk22] RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Naoto Sato
On Thu, 11 Jan 2024 22:56:38 GMT, Joe Wang wrote: > Backport to fix the regression introduced in JDK 22. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/63#pullrequestreview-1817006707

[jdk22] RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Joe Wang
Backport to fix the regression introduced in JDK 22. - Commit messages: - Backport e4389d8dc224419b8c1ee08e9f2dea0f103c6845 Changes: https://git.openjdk.org/jdk22/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk22=63=00 Issue:

Re: RFR: 8323571: Regression in source resolution process [v2]

2024-01-11 Thread Joe Wang
> Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make the null-check on InputSource the first. > > Test

Re: RFR: 8323571: Regression in source resolution process [v2]

2024-01-11 Thread Joe Wang
On Thu, 11 Jan 2024 20:35:33 GMT, Naoto Sato wrote: > LGTM. If the file was modified this year, put 2024 in the header Copyright year fixed. Thanks. - PR Comment: https://git.openjdk.org/jdk/pull/17377#issuecomment-1887951201

Re: RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Naoto Sato
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote: > Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make

Re: RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Lance Andersen
On Thu, 11 Jan 2024 18:36:39 GMT, Joe Wang wrote: > Fix a regression in the source resolution process where it failed to > recognize a custom InputSource when both the public and system IDs are null. > The particular issue is fixed at line 1233, the rest of the changes is > formatting to make

RFR: 8323571: Regression in source resolution process

2024-01-11 Thread Joe Wang
Fix a regression in the source resolution process where it failed to recognize a custom InputSource when both the public and system IDs are null. The particular issue is fixed at line 1233, the rest of the changes is formatting to make the null-check on InputSource the first. Test is provided