Re: RFR: 8323746: Add PathElement hashCode and equals [v2]

2024-02-08 Thread Per Minborg
On Sat, 3 Feb 2024 11:28:51 GMT, ExE Boss wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make all PathElements records > > src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java line 494: > >> 492:

Re: RFR: 8323746: Add PathElement hashCode and equals [v2]

2024-02-03 Thread ExE Boss
On Fri, 2 Feb 2024 07:41:16 GMT, Per Minborg wrote: >> This PR proposes to implement `hashCode()` and `equals()` methods for >> implementations of `PathElement`. >> >> In doing so, the previous `PathElementImpl` was removed and replaced in >> favor of distinct `record` implementations, each

Re: RFR: 8323746: Add PathElement hashCode and equals [v2]

2024-02-03 Thread Maurizio Cimadamore
On Fri, 2 Feb 2024 07:41:16 GMT, Per Minborg wrote: >> This PR proposes to implement `hashCode()` and `equals()` methods for >> implementations of `PathElement`. >> >> In doing so, the previous `PathElementImpl` was removed and replaced in >> favor of distinct `record` implementations, each

Re: RFR: 8323746: Add PathElement hashCode and equals [v2]

2024-02-01 Thread Per Minborg
> This PR proposes to implement `hashCode()` and `equals()` methods for > implementations of `PathElement`. > > In doing so, the previous `PathElementImpl` was removed and replaced in favor > of distinct `record` implementations, each reflecting its own path element > selection type. This also