On Fri, 19 Jan 2024 08:17:00 GMT, Richard Reingruber wrote:
> Do you want to keep it then or should I open an RFE to remove it?
Maybe leave it for now as there is significant churn in this code right now,
with more accumulating in the loom repo in advance of the monitors work.
-
On Fri, 19 Jan 2024 07:57:36 GMT, Alan Bateman wrote:
> > I noticed that VirtualThread overrides `isInterrupted`
> > Is there a reason to have this override?
>
> It was necessary at one point but no reason to now except to keep it close at
> the source level with the other methods that access
On Fri, 19 Jan 2024 01:56:06 GMT, David Holmes wrote:
> Yep my bad on the VM side of things - no change there. But in the nioBlocker
> case doesn't this inherently make things more racy? Now maybe those races are
> allowed, but this might lead to a change in behaviour.
I/O threads always
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
On Thu, 18 Jan 2024 09:21:24 GMT, Richard Reingruber wrote:
>>> It is really safe/correct to move this outside the synchronized block? I
>>> know things have changed a bit with loom but we've "always" held a lock
>>> when doing the actual interrupt. I'd have to check the VM logic to be sure
On Thu, 18 Jan 2024 08:32:02 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/Thread.java line 1709:
>>
>>> 1707: // Setting the interrupt status must be done before reading
>>> nioBlocker.
>>> 1708: interrupted = true;
>>> 1709: interrupt0(); //
On Thu, 18 Jan 2024 08:02:27 GMT, David Holmes wrote:
> It is really safe/correct to move this outside the synchronized block? I know
> things have changed a bit with loom but we've "always" held a lock when doing
> the actual interrupt. I'd have to check the VM logic to be sure it can be
>
On Wed, 17 Jan 2024 21:18:27 GMT, Christoph Langer wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Alan
>
> test/jdk/java/nio/channels/Selector/LotsOfInterrupts.java line 2:
>
>> 1: /*
>> 2: *
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>>
> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
> correct (Dekker scheme) synchronization with concurrent execution of
>
14 matches
Mail list logo
