On Fri, 2 Feb 2024 21:20:29 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR to fix to a regression in ZipFileSystem, introduced by
>> JDK-8322565 in PR #17170.
>>
>> When `Files.setPosixFilePermissions` is called on an existing MSDOS entry,
>> then `Entry.posixPerms` field will be -1 (all
On Fri, 2 Feb 2024 21:17:48 GMT, Eirik Bjørsnøs wrote:
>> test/jdk/jdk/nio/zipfs/TestPosix.java line 757:
>>
>>> 755: try (FileSystem fs = FileSystems.newFileSystem(ZIP_FILE,
>>> ENV_POSIX)) {
>>> 756: Path path = fs.getPath("hello.txt");
>>> 757: Files.setPosixF
On Fri, 2 Feb 2024 20:01:06 GMT, Lance Andersen wrote:
> It might be helpful to show the before/after output of the CEN fields here
> just for extra clarity
Thanks! Can you take a look at 4bb77e1 which shows the `zipdetails` output for
relevant fields before/after calling `setPosixFilePermissi
> Please review this PR to fix to a regression in ZipFileSystem, introduced by
> JDK-8322565 in PR #17170.
>
> When `Files.setPosixFilePermissions` is called on an existing MSDOS entry,
> then `Entry.posixPerms` field will be -1 (all 1s in binary). The logic
> introduced by JDK-8322565 did not
