Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-29 Thread ExE Boss
On Wed, 3 Apr 2024 07:13:13 GMT, Jan Lahoda wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java >> line 1415: >> >>> 1413: >>> canonicalConstructorTypes, >>> 1414:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-05 Thread Maurizio Cimadamore
On Thu, 4 Apr 2024 20:27:36 GMT, Jan Lahoda wrote: >> src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java >> line 133: >> >>> 131: */ >>> 132: >>> @PreviewFeature(feature=PreviewFeature.Feature.DERIVED_RECORD_CREATION, >>> reflective=true) >>> 133:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-05 Thread Jan Lahoda
On Thu, 4 Apr 2024 17:00:33 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing tests. > > src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java > line 1574: > >> 1572:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-05 Thread Jan Lahoda
On Thu, 4 Apr 2024 16:47:07 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing tests. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java line 2235: > >> 2233:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-04 Thread Jan Lahoda
On Thu, 4 Apr 2024 00:37:45 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing tests. > > src/java.compiler/share/classes/javax/lang/model/element/ElementKind.java > line 133: > >> 131:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-04 Thread Vicente Romero
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >>

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-03 Thread Jan Lahoda
On Tue, 2 Apr 2024 12:50:19 GMT, ExE Boss wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing tests. > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java > line 1415: > >> 1413:

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-03 Thread Joe Darcy
On Tue, 2 Apr 2024 18:09:52 GMT, Joe Darcy wrote: > > For the `javax.lang.model` changes, as a new ElementKind is being > > introduced, there should be a matching layer of new concrete visitors and > > selected updates to existing visitor implementations, etc. > > I can help develop the

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-02 Thread Joe Darcy
On Tue, 2 Apr 2024 18:05:43 GMT, Joe Darcy wrote: > For the `javax.lang.model` changes, as a new ElementKind is being introduced, > there should be a matching layer of new concrete visitors and selected > updates to existing visitor implementations, etc. I can help develop the visitor changes

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-02 Thread Joe Darcy
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >>

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-04-02 Thread ExE Boss
On Thu, 28 Mar 2024 14:08:44 GMT, Jan Lahoda wrote: >> This is a patch for javac, that adds the Derived Record Creation >> expressions. The current draft specification for the feature is: >> https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html >> >>

Re: RFR: 8324651: Compiler Implementation for Derived Record Creation (Preview) [v5]

2024-03-28 Thread Jan Lahoda
> This is a patch for javac, that adds the Derived Record Creation expressions. > The current draft specification for the feature is: > https://cr.openjdk.org/~gbierman/jep468/jep468-20240326/specs/derived-record-creation-jls.html > > The current CSR is here: >