On Tue, 27 Feb 2024 00:34:49 GMT, Serguei Spitsyn wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address plummercj's comment and make forkedChildProcess static.
>> - Revert src/java.base/unix/native/libjava/chi
On Mon, 26 Feb 2024 22:55:06 GMT, Jiangli Zhou wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate
>> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
>> thanks.
>
> Jiangli Zhou has updated the pull request incrementally with two additi
On Mon, 26 Feb 2024 23:50:11 GMT, Chris Plummer wrote:
> Looks good.
Thanks for the quick review, @plummercj.
-
PR Comment: https://git.openjdk.org/jdk/pull/18013#issuecomment-1965539618
On Mon, 26 Feb 2024 22:55:06 GMT, Jiangli Zhou wrote:
>> Please help review this trivial fix for resolving `ld: error: duplicate
>> symbol: closeDescriptors` when static linking with both libjdwp and libjava,
>> thanks.
>
> Jiangli Zhou has updated the pull request incrementally with two additi
On Mon, 26 Feb 2024 20:37:45 GMT, Chris Plummer wrote:
>> Jiangli Zhou has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address plummercj's comment and make forkedChildProcess static.
>> - Revert src/java.base/unix/native/libjava/child
On Mon, 26 Feb 2024 22:15:00 GMT, Jiangli Zhou wrote:
>> src/java.base/unix/native/libjava/childproc.h line 134:
>>
>>> 132: int closeSafely(int fd);
>>> 133: int isAsciiDigit(char c);
>>> 134: int closeDescriptors(void);
>>
>> It seems that most of the APIs in this file should be static. I don