On Tue, 12 Mar 2024 13:55:11 GMT, Magnus Ihse Bursie wrote:
>> test/hotspot/jtreg/runtime/ErrorHandling/libTestDwarfHelper.h line 24:
>>
>>> 22: */
>>> 23:
>>> 24: #include
>>
>> Seems unneeded.
>
> So what I did here was change:
>
> #include "jni.h"
> #include
>
>
> into
>
> #include
On Tue, 12 Mar 2024 13:51:28 GMT, Magnus Ihse Bursie wrote:
>> test/jdk/java/foreign/CallGeneratorHelper.java line 216:
>>
>>> 214: if (header) {
>>> 215: System.out.println(
>>> 216: "#include \"export.h\"\n"
>>
>> We don't generate these header files any
On Mon, 11 Mar 2024 06:57:58 GMT, Alan Bateman wrote:
> Good cleanup.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/18135#issuecomment-1991712859
On Mon, 11 Mar 2024 02:31:02 GMT, David Holmes wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update line number for dereference_null in TestDwarf
>
>
On Fri, 8 Mar 2024 18:12:40 GMT, Jorn Vernee wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update line number for dereference_null in TestDwarf
>
> test/jdk/java/foreign/CallGeneratorHelper.java line 216:
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>>
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>>
On Wed, 6 Mar 2024 13: 43: 00 GMT, Magnus Ihse Bursie wrote: >> Currently, our symbol visibility handling for tests are sloppy; we only handle it properly on Windows. We need to bring it up to the same levels as
ZjQcmQRYFpfptBannerStart
This Message Is From an
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>>
On Wed, 6 Mar 2024 13:53:06 GMT, Magnus Ihse Bursie wrote:
> I am currently running tier 4-10
This is now done. A handful of tests failed, but all are due to transient
environmental problems, known errors, or seemingly intermittent product errors
-- none are due to symbol visibility.
So I'd
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>>
On Wed, 6 Mar 2024 13:43:00 GMT, Magnus Ihse Bursie wrote:
>> Currently, our symbol visibility handling for tests are sloppy; we only
>> handle it properly on Windows. We need to bring it up to the same levels as
>> product code. This is a prerequisite for
>>
> Currently, our symbol visibility handling for tests are sloppy; we only
> handle it properly on Windows. We need to bring it up to the same levels as
> product code. This is a prerequisite for
> [JDK-8327045](https://bugs.openjdk.org/browse/JDK-8327045), which in turn is
> a building block
13 matches
Mail list logo
