On Mon, 25 Mar 2024 22:23:03 GMT, Jesper Wilhelmsson
wrote:
>> The problem is that the project is a joined work and has multiple variants
>> of copyrights (see the readme). I don’t think it’s on the safe side to pick
>> a single (non recent) copyright - especially if you change attribution
On Mon, 25 Mar 2024 20:40:50 GMT, Bernd wrote:
>> That header only contains a single function declaration for an entry point
>> into the implementation.
>> HotSpot doesn't use that function, and doesn't have anything with a
>> corresponding signature. So it's
>> not in any way derived from
On Mon, 25 Mar 2024 20:34:06 GMT, Kim Barrett wrote:
>> The header file contains more claims
>> https://github.com/veorq/SipHash/blob/master/halfsiphash.h
>
> That header only contains a single function declaration for an entry point
> into the implementation.
> HotSpot doesn't use that
On Mon, 25 Mar 2024 20:10:45 GMT, Bernd wrote:
>> To match the license claim in the code we are using:
>> https://github.com/openjdk/jdk/blob/fb8f2a0a929ebe7f65c69741712b89bbb403ade9/src/hotspot/share/classfile/altHashing.cpp#L32-L43
>
> The header file contains more claims
>
On Mon, 25 Mar 2024 20:07:02 GMT, Kim Barrett wrote:
>> src/hotspot/share/legal/siphash.md line 9:
>>
>>> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson
>>> 8:
>>> 9:Copyright (c) 2012-2014 Daniel J. Bernstein
>>
>> Why would you remove a author or year range?
>
> To match the
On Sun, 24 Mar 2024 17:24:49 GMT, Bernd wrote:
>> Updated and moved the license file.
>
> src/hotspot/share/legal/siphash.md line 9:
>
>> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson
>> 8:
>> 9:Copyright (c) 2012-2014 Daniel J. Bernstein
>
> Why would you remove a author or
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson
wrote:
> Updated and moved the license file.
src/hotspot/share/legal/siphash.md line 9:
> 7:Copyright (c) 2012-2021 Jean-Philippe Aumasson
> 8:
> 9:Copyright (c) 2012-2014 Daniel J. Bernstein
Why would you remove a author or
On Fri, 22 Mar 2024 15:18:29 GMT, Jesper Wilhelmsson
wrote:
> Updated and moved the license file.
Looks good.
Lois
-
Marked as reviewed by lfoltan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18455#pullrequestreview-1955180960
Updated and moved the license file.
-
Commit messages:
- 8328812: Update and move siphash license
Changes: https://git.openjdk.org/jdk/pull/18455/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18455=00
Issue: https://bugs.openjdk.org/browse/JDK-8328812
Stats: 4 lines in
