Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-20 Thread Viktor Klang
On Mon, 20 May 2024 14:49:13 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moving the memory leak test for SynchronousQueue into its own test and >> runs only for JDK20+, using VirtualThreads >

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-20 Thread Alan Bateman
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. Regression test added for JDK20+ > > Viktor Klang has updated the pull request incrementally with one additional > commit

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Viktor Klang
On Fri, 17 May 2024 13:49:44 GMT, Doug Lea wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moving the memory leak test for SynchronousQueue into its own test and >> runs only for JDK20+, using VirtualThreads > > S

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Doug Lea
On Fri, 17 May 2024 13:19:19 GMT, Viktor Klang wrote: >> Local testing seems to indicate that this fix (which mirrors what's done in >> the FIFO mode) addresses the problem. >> >> But with that said, I haven't come up with a decent way of adding some form >> of regression test. Suggestions are

Re: RFR: 8332154: Memory leak in SynchronousQueue [v3]

2024-05-17 Thread Viktor Klang
> Local testing seems to indicate that this fix (which mirrors what's done in > the FIFO mode) addresses the problem. > > But with that said, I haven't come up with a decent way of adding some form > of regression test. Suggestions are most welcome. /cc @DougLea Viktor Klang has updated the pul