On Fri, 28 Feb 2025 22:36:32 GMT, Alexey Semenyuk wrote:
>> Add a test to verify jpackage is using a custom MSI condition blocking
>> package installation depending on the version of Windows where the package
>> installer runs. Support for this MSI condition was added in
>> [JDK-8150442](https
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
>
> The test adds an
On Fri, 28 Feb 2025 01:34:22 GMT, Alexander Matveev
wrote:
> With `->` it should not fall into next case. Maybe I am missing something.
Right, but there are two `siwtch` blocks in the function. Without `return` the
control flow will get to the second one. `return`-s prevents this.
---
On Fri, 28 Feb 2025 01:17:19 GMT, Alexey Semenyuk wrote:
> Yes. It should exit the function early to avoid jumping in the next switch
> block.
With `->` it should not fall into next case. Maybe I am missing something.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23825#dis
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
>
> The test adds an
On Thu, 27 Feb 2025 23:48:19 GMT, Alexander Matveev
wrote:
> Do we really need return here and at line 495?
Yes. It should exit the function early to avoid jumping in the next `switch`
block.
> do you think it might be better to make `switch` consistent?
Totally!
-
PR Review Co
On Thu, 27 Feb 2025 14:17:30 GMT, Alexey Semenyuk wrote:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://b
On Thu, 27 Feb 2025 14:17:30 GMT, Alexey Semenyuk wrote:
> Add a test to verify jpackage is using a custom MSI condition blocking
> package installation depending on the version of Windows where the package
> installer runs. Support for this MSI condition was added in
> [JDK-8150442](https://b
Add a test to verify jpackage is using a custom MSI condition blocking package
installation depending on the version of Windows where the package installer
runs. Support for this MSI condition was added in
[JDK-8150442](https://bugs.openjdk.org/browse/JDK-8150442).
The test adds an unconditiona
