On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [x] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not con
On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [x] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not con
On Wed, 9 Jul 2025 19:38:21 GMT, Chen Liang wrote:
>>> The changes are OK.
>>
>> Great, @LanceAndersen! Thanks for reviewing. 😃
>>
>> Can you integrate it when you think it is appropriate? I guess I do not have
>> permission to do it.
>
>> Can you integrate it when you think it is appropriate
On Wed, 9 Jul 2025 19:35:54 GMT, simon wrote:
> Can you integrate it when you think it is appropriate? I guess I do not have
> permission to do it.
They are done with GitHub comments parsed by bots, so if there is a line:
> /integrate
in a comment from you, the bot will integrate this patch (
On Wed, 9 Jul 2025 18:59:49 GMT, Lance Andersen wrote:
> The changes are OK.
Great, @LanceAndersen! Thanks for reviewing. 😃
Can you integrate it when you think it is appropriate? I guess I do not have
permission to do it.
-
PR Comment: https://git.openjdk.org/jdk/pull/25925#issu
On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [x] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not con
On Tue, 8 Jul 2025 18:53:08 GMT, Lance Andersen wrote:
>> It was just a suggestion, but it’s not really related to the main change. I
>> can undo it if you think it’s appropriate
>
> Please revert this change
Fixed
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discus
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Thu, 3 Jul 2025 01:44:27 GMT, simon wrote:
>> src/java.sql/share/classes/java/sql/Connection.java line 303:
>>
>>> 301:
>>> //==
>>> 302: // Advanced features:
>>> 303:
>>
>> Why was this removed as this is not for
On Mon, 23 Jun 2025 17:45:02 GMT, Lance Andersen wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> I might not have
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Wed, 2 Jul 2025 15:14:47 GMT, Lance Andersen wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: revert reformatting method signatures
>
> src/java.sql/share/classes/java/sql/Connection.java line 1175:
>
>> 1173:
On Wed, 2 Jul 2025 14:37:04 GMT, Lance Andersen wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: revert reformatting method signatures
>
> src/java.sql/share/classes/java/sql/Connection.java line 303:
>
>> 301:
On Mon, 23 Jun 2025 23:09:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 17:45:02 GMT, Lance Andersen wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> I might not have
On Mon, 23 Jun 2025 23:09:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 19:54:24 GMT, Roger Riggs wrote:
>> @RogerRiggs My preferred formatting style is like this:
>>
>>
>> default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>> ShardingKey superShardingKey,
>>
On Mon, 23 Jun 2025 18:38:00 GMT, simon wrote:
>> src/java.sql/share/classes/java/sql/Connection.java line 1597:
>>
>>> 1595: default boolean setShardingKeyIfValid(ShardingKey shardingKey,
>>> 1596: ShardingKey
>>> superShardingKey,
>>> 1597:
On Mon, 23 Jun 2025 17:35:50 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> src/java.sql/share/cl
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
>> simon has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8360122: refactor code formatting to enforce 100 chars line length limit
>> for improved readability
>
> The indentation fixes
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must
On Mon, 23 Jun 2025 14:51:44 GMT, Chen Liang wrote:
> FYI people don't usually review on weekends (you opened this PR in a weekend)
> or holidays. This PR is sent to core-libs-dev list so people will eventually
> see and review it.
Great, @liach! Thanks for the information! 😄
-
P
On Mon, 23 Jun 2025 14:50:24 GMT, Roger Riggs wrote:
> The indentation fixes look ok. The reformatting of declarations seem
> unnecessary and create lines that are longer than desirable to be able to do
> side-by-side compares (100 char max). Generally, avoid just asking the IDE to
> re-format
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
On Sun, 22 Jun 2025 01:13:26 GMT, simon wrote:
> 8360122: Refine formatting of Connection.java interface
>
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] Change must not contain e
8360122: Refine formatting of Connection.java interface
-
### Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1
[Reviewer](https://openjdk.org/bylaws#reviewer))
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issu
31 matches
Mail list logo
