Re: RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted [v5]

2023-09-20 Thread Naoto Sato
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote: >> Please review this PR which restricts sub-classing of the internal calendar >> system in sun.util.calendar to only the existing implementations. Drive by >> cleanup included. >> >> As the implementation is long-standing and complete with

Re: RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted [v5]

2023-09-20 Thread Naoto Sato
On Wed, 20 Sep 2023 08:54:55 GMT, Andrey Turbanov wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - cleanup CalendarDate after revert >> - Revert "Replace sprintf0d with Formatter" >> >>This reverts commit

Re: RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted [v5]

2023-09-20 Thread Andrey Turbanov
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote: >> Please review this PR which restricts sub-classing of the internal calendar >> system in sun.util.calendar to only the existing implementations. Drive by >> cleanup included. >> >> As the implementation is long-standing and complete with

Re: RFR: JDK-8316435: sun.util.calendar.CalendarSystem subclassing should be restricted [v5]

2023-09-20 Thread Justin Lu
> Please review this PR which restricts sub-classing of the internal calendar > system in sun.util.calendar to only the existing implementations. Drive by > cleanup included. > > As the implementation is long-standing and complete with no intent for future > sub-classing, the CalendarSystem