> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
On Fri, 22 Sep 2023 20:45:39 GMT, Lance Andersen wrote:
> Overall, this is fine.
>
> I would like to suggest comments to introduce all tests and DataProviders.
> Extra credit for helper methods.
>
> From a future maintainers Point of view, having more info in the tests is
> beneficial.
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after
On Fri, 22 Sep 2023 19:44:00 GMT, Justin Lu wrote:
>> test/jdk/java/util/Calendar/Bug4766302.java line 32:
>>
>>> 30: import java.util.GregorianCalendar;
>>> 31:
>>> 32: @SuppressWarnings("serial")
>>
>> Is removing this OK?
>
> At first I thought so, there is no warning about a missing
On Thu, 21 Sep 2023 22:18:04 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
>
>
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally
On Fri, 22 Sep 2023 06:44:16 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
>
>
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
On Wed, 20 Sep 2023 23:20:43 GMT, Justin Lu wrote:
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Please review this PR which converts some tests under _Calendar_ to use JUnit.
These tests either previously used the internal _IntlTest_, or used no
framework at all.
Any files named BugXXX.java will be renamed after review.
-
Commit messages:
- Separate data generation and
14 matches
Mail list logo
