Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v8]

2023-12-06 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update copyright year. - Changes: - all: https://git.openjdk.org/jdk/pull/16505/files - new:

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v7]

2023-12-06 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v6]

2023-12-06 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Regenerate JDK 22 symbol files. - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v5]

2023-12-04 Thread Iris Clark
On Tue, 5 Dec 2023 01:48:14 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 15 commits: > > - Merge branch 'master' into JDK-8319413 > - Add

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-04 Thread Iris Clark
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update symbol files to JDK 22 b26. > > test/langtools/tools/javac/versions/Versions.java line 97: > >> 95:

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v5]

2023-12-04 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits: - Merge branch 'master' into JDK-8319413 - Add symbol files. - Merge branch 'master' into JDK-8319413 - Merge

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-02 Thread Andrey Turbanov
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26.

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-02 Thread Joe Darcy
On Fri, 1 Dec 2023 08:54:06 GMT, Alan Bateman wrote: > Looks good. I assume you'll bump the copyright header on the files that need > it before integration, e.g. JavacTestingAbstractProcessor. Right; I run a script to update the years of modified files. - PR Comment:

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-01 Thread Vicente Romero
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. looks good to me - Marked

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-12-01 Thread Alan Bateman
On Thu, 30 Nov 2023 23:49:24 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files to JDK 22 b26. Good good. I assume you'll bump the

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]

2023-11-30 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update symbol files to JDK 22 b26. - Changes: - all: https://git.openjdk.org/jdk/pull/16505/files - new:

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v3]

2023-11-30 Thread Iris Clark
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains eight commits: > > - Merge branch 'master' into JDK-8319413 > -

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v3]

2023-11-30 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into JDK-8319413 - Add symbol files for JDK

Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v2]

2023-11-29 Thread Joe Darcy
> Time to start making preparations for JDK 23. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge branch 'master' into JDK-8319413 - Add symbol files for JDK 22 build 25. - Merge branch 'master' into

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-28 Thread Erik Joelsson
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Build changes look good. - Marked as reviewed by erikj (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1754115586

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread David Holmes
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Hotspot change is trivially fine, but too insignificant to hit the Approve button. Thanks - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1752152672

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Iris Clark
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1751551968

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Nothing exception in this batch of start-of-release updates. Clean local testing results on tier 1. The symbol files correspond to JDK 22 build 25 and will be updated with subsequent builds as

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Chen Liang
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Changes requested by liach (Author). src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 1: > 1: /* `latestMajorVersion` below should be updated to return `JAVA_23_VERSION` as

RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
Time to start making preparations for JDK 23. - Commit messages: - Add symbol files for JDK 22 build 25. - Merge branch 'master' into JDK-8319413 - Merge branch 'master' into JDK-8319413 - Adjust expected release date. - Fix omission in Classfile.java - JDK-8319413: Start of

Re: RFR: JDK-8319413: Start of release updates for JDK 23

2023-11-27 Thread Joe Darcy
On Fri, 3 Nov 2023 23:52:45 GMT, Chen Liang wrote: >> Time to start making preparations for JDK 23. > > src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 1: > >> 1: /* > > `latestMajorVersion` below should be updated to return `JAVA_23_VERSION` as > well. Good catch;