On Fri, 1 Dec 2023 08:49:34 GMT, Alan Bateman wrote:
>> Thanks Jai, that makes sense. Replaced full path with just the base name in
>> latest commit.
>
> I think the second paragraph of the method description is problematic.
> Documenting the representation and then saying it is subject to
On Thu, 30 Nov 2023 21:08:35 GMT, Justin Lu wrote:
>> Hello Justin,
>>
>>> I am not sure if you have a preference one way or another regarding
>>> providing the full path versus just the file name, but I can switch the
>>> full path for just the file name if need be.
>>
>> My opinion is that
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
Justin Lu has updated the pull request incrementally with one additional
On Thu, 30 Nov 2023 10:17:23 GMT, Jaikiran Pai wrote:
>> I like the new wording (have no oppinion if absolute path is better).
>
> Hello Justin,
>
>> I am not sure if you have a preference one way or another regarding
>> providing the full path versus just the file name, but I can switch the
