Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-22 Thread Justin Lu
On Fri, 12 Jan 2024 21:30:05 GMT, Roger Riggs wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains eight additional commits >>

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Roger Riggs
On Fri, 12 Jan 2024 19:07:46 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Naoto Sato
On Fri, 12 Jan 2024 19:07:46 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns.