Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v5]

2023-05-15 Thread Justin Lu
> Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in addition to some cleanup. No functionality is changed, > the Locale equ

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v4]

2023-05-12 Thread Naoto Sato
On Fri, 12 May 2023 17:25:45 GMT, Justin Lu wrote: >> Please review changes to `EquivMapsGenerator.java` (which is used to >> generate the Locale equivalencies for the JDK). >> >> The file previously used large concatenated Strings, which are now replaced >> with text blocks, in addition to so

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

2023-05-12 Thread Justin Lu
On Fri, 12 May 2023 16:41:18 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove more ws in text block > > make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java > line 344:

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v4]

2023-05-12 Thread Justin Lu
> Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in addition to some cleanup. No functionality is changed, > the Locale equ

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

2023-05-12 Thread Naoto Sato
On Thu, 11 May 2023 22:23:47 GMT, Justin Lu wrote: >> Please review changes to `EquivMapsGenerator.java` (which is used to >> generate the Locale equivalencies for the JDK). >> >> The file previously used large concatenated Strings, which are now replaced >> with text blocks, in addition to so

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v3]

2023-05-11 Thread Justin Lu
> Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in addition to some cleanup. No functionality is changed, > the Locale equ

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v2]

2023-05-11 Thread Justin Lu
On Thu, 11 May 2023 20:34:48 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Adjust new lines to appease jcheck? >> - Review: remove new line literals for new lines >> - Review: fix method / var

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java [v2]

2023-05-11 Thread Justin Lu
> Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in addition to some cleanup. No functionality is changed, > the Locale equ

Re: RFR: 8306597: Improve string formatting in EquivMapsGenerator.java

2023-05-11 Thread Naoto Sato
On Thu, 11 May 2023 15:40:50 GMT, Justin Lu wrote: > Please review changes to `EquivMapsGenerator.java` (which is used to generate > the Locale equivalencies for the JDK). > > The file previously used large concatenated Strings, which are now replaced > with text blocks, in addition to some cl