Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Wed, 23 Nov 2022 06:58:09 GMT, Dongxu Wang wrote: > 8297385: Remove duplicated null typos in javadoc Looks good. - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.org/jdk/pull/11311
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Wed, 23 Nov 2022 06:58:09 GMT, Dongxu Wang wrote: > 8297385: Remove duplicated null typos in javadoc LGTM - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.org/jdk/pull/11311
RFR: 8297385: Remove duplicated null typos in javadoc
8297385: Remove duplicated null typos in javadoc - Commit messages: - 8297385: Remove duplicated null typo in javadoc Changes: https://git.openjdk.org/jdk/pull/11311/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11311=00 Issue: https://bugs.openjdk.org/browse/JDK-8297385 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11311.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11311/head:pull/11311 PR: https://git.openjdk.org/jdk/pull/11311
Re: RFR: 8297385: Remove duplicated null typos in javadoc [v2]
On Wed, 23 Nov 2022 06:49:56 GMT, Dongxu Wang wrote: >> 8297385: Remove duplicated null typos in javadoc > > Dongxu Wang has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'openjdk:master' into master > - Minor remove duplicate null typo Use #11311 instead, close this pr. - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc [v2]
On Wed, 23 Nov 2022 06:43:56 GMT, Yi Yang wrote: > This looks good, but I'm not a Reviewer, you still need an approval from > Reviewer. Thanks - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc [v2]
> 8297385: Remove duplicated null typos in javadoc Dongxu Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into master - Minor remove duplicate null typo - Changes: - all: https://git.openjdk.org/jdk/pull/11169/files - new: https://git.openjdk.org/jdk/pull/11169/files/65327c89..f731384b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=11169=01 - incr: https://webrevs.openjdk.org/?repo=jdk=11169=00-01 Stats: 44876 lines in 726 files changed: 16653 ins; 16626 del; 11597 mod Patch: https://git.openjdk.org/jdk/pull/11169.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11169/head:pull/11169 PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc [v2]
On Wed, 23 Nov 2022 06:45:26 GMT, Dongxu Wang wrote: >> 8297385: Remove duplicated null typos in javadoc > > Dongxu Wang has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'openjdk:master' into master > - Minor remove duplicate null typo This looks good, but I'm not a Reviewer, you still need an approval from Reviewer. - Marked as reviewed by yyang (Committer). PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote: > 8297385: Remove duplicated null typos in javadoc The source of this PR is the "master" branch of your fork. Note the Comment from the bot at the top. The conventional usage is to create a branch specific to the change you are making and create the PR from that. You will run into trouble with git due to any commits in the master branch other than are pulled from the mainline. You can create the new branch from your current master and then reset the HEAD of the master back to match the mainline head. - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Tue, 22 Nov 2022 03:33:55 GMT, Yi Yang wrote: > > > good catch, do you need a JBS issue for this? > > > > > > Thank you if you can help with that. > > I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change > your PR title and commit message to [8297385: Remove duplicated null typo in > javadoc](https://bugs.openjdk.org/browse/JDK-8297385), OpenJDK robot will > guide you remaining processes. Thank you, can you also help review - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Tue, 15 Nov 2022 15:05:45 GMT, Dongxu Wang wrote: > 8297385: Remove duplicated null typos in javadoc good catch, do you need a JBS issue for this? - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Tue, 22 Nov 2022 02:22:20 GMT, Dongxu Wang wrote: > > good catch, do you need a JBS issue for this? > > Thank you if you can help with that. I filed https://bugs.openjdk.org/browse/JDK-8297385 for this, you can change your PR title and commit message to [8297385: Remove duplicated null typo in javadoc](https://bugs.openjdk.org/browse/JDK-8297385), OpenJDK robot will guide you remaining processes. - PR: https://git.openjdk.org/jdk/pull/11169
Re: RFR: 8297385: Remove duplicated null typos in javadoc
On Mon, 21 Nov 2022 15:16:14 GMT, Yi Yang wrote: > good catch, do you need a JBS issue for this? Thank you if you can help with that. - PR: https://git.openjdk.org/jdk/pull/11169
RFR: 8297385: Remove duplicated null typos in javadoc
8297385: Remove duplicated null typos in javadoc - Commit messages: - Minor remove duplicate null typo Changes: https://git.openjdk.org/jdk/pull/11169/files Webrev: https://webrevs.openjdk.org/?repo=jdk=11169=00 Issue: https://bugs.openjdk.org/browse/JDK-8297385 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11169.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11169/head:pull/11169 PR: https://git.openjdk.org/jdk/pull/11169
