Hi
This is motivated by Neil's request to optimize common-case UTF8 path
for native ZipFile.getEntry calls [1].
As I said in my replying email [2] I believe a better approach might be
to patch UTF8 charset directly to
implement sun.nio.cs.ArrayDecoder/Encoder interface to speed up the
coding
Xueming Shen wrote:
Hi
This is motivated by Neil's request to optimize common-case UTF8 path
for native ZipFile.getEntry calls [1].
As I said in my replying email [2] I believe a better approach might
be to patch UTF8 charset directly to
implement sun.nio.cs.ArrayDecoder/Encoder interface to
Hi,
Is this the right list?
I am being confused by an error 'Could not find agent library on the
library path or in the local directory: instrument'. Could anyone has
ideas?
My jdk version is 1.5.
Thank you in advance.
--
Best Wishes
Yongqiang Yang
No answer ?
Especially on:
static constant vs. static method
-Ulf
Am 20.04.2011 13:47, schrieb Ulf Zibis:
Am 20.04.2011 02:23, schrieb Mike Duigou:
On Apr 19 2011, at 04:52 , Ulf Zibis wrote:
I think, we should catch the problem at the source. ... In my approach from Bug
100098 - Make
On 27/04/11 13:51, Maurizio Cimadamore wrote:
On 27/04/11 09:18, David Holmes wrote:
Special-casing Throwable wouldn't be sufficient as people may use
Exception instead.
I guess this doesn't invalidate the argument - we could special-case
Exception AND Throwable, since they are already
Maurizio Cimadamore said the following on 04/28/11 21:56:
On 27/04/11 13:51, Maurizio Cimadamore wrote:
On 27/04/11 09:18, David Holmes wrote:
Special-casing Throwable wouldn't be sufficient as people may use
Exception instead.
I guess this doesn't invalidate the argument - we could
Changeset: 76703c84b3a2
Author:weijun
Date: 2011-04-28 20:34 +0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76703c84b3a2
7037201: regression: invalid signed jar file not detected
Reviewed-by: mullan
! src/share/classes/java/util/jar/JarFile.java
!
Interesting results!
Some days ago we had the discussion about constants for standard Charsets.
Looking at your results, I see, that using *charset names constants*, the conversion mostly performs
little better (up to 25 %), than using *charset constants*.
So again my question: Why do we need
According to comments in 6795537
I additionally assume
else if (b1 (byte)0xc2)
should be little faster than
else if ((b1 5) == -2)
and
if (isMalformed2(b1, b2))
could be replaced by
if (isNotContinuation(b2))
-Ulf
Am 28.04.2011 14:44, schrieb Ulf Zibis:
Interesting
Changeset: 28caa191884a
Author:lancea
Date: 2011-04-28 09:46 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a
7038565: address Findbugs issue in BatchUpdateException
Reviewed-by: alanb, forax
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: c3f5333e10e3
Author:mchung
Date: 2011-04-28 08:51 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c3f5333e10e3
7037081: Remove com.sun.tracing from NON_CORE_PKGS
Reviewed-by: ohair, jjg, jmasa
! make/docs/Makefile
! make/docs/NON_CORE_PKGS.gmk
Changeset: c7841bbe1227
Author:mchung
Date: 2011-04-28 08:46 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c7841bbe1227
7037081: Remove com.sun.tracing from NON_CORE_PKGS
Reviewed-by: ohair, jjg, jmasa
!
Hey Mike,
why didn't you follow Mark's explanation about the naming for
StandardCharset(s) ?
Did you have had other discussions internally?
-Ulf
Am 27.04.2011 23:18, schrieb mike.dui...@oracle.com:
Changeset: 5b05f8d1c0e5
Author:mduigou
Date: 2011-04-26 14:25 -0700
URL:
Changeset: 37722a0a1c65
Author:mduigou
Date: 2011-04-28 10:12 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/37722a0a1c65
7040381: Add StandardCharset.java to FILES_java.gmk
Reviewed-by: alanb
! make/java/nio/FILES_java.gmk
Changeset: 7b7c1ffd0752
Author:mduigou
Date:
Essentially we ran out of time for this task and were confident enough in out
decision about the design and choice of names to go ahead. More discussion
didn't seem to be leading anywhere but inaction and there are other issues
(always) that need attention.
Mike
On Apr 28 2011, at 10:15 ,
Hi all,
I could use a reviewer for 7040150 which addresses a positioning issue with
CacheResultSetImpl.removeCurrentRow().
The diff is located at:
http://cr.openjdk.java.net/~lancea/7040150/webrev.00/
Thank you.
Regards,
Lance
Lance Andersen| Principal Member of Technical Staff |
On 04/28/2011 05:44 AM, Ulf Zibis wrote:
In malformed(byte[] src, int sp, int nb) I think you could cache the
ByteBuffer bb, instead instantiating a new one all the time. For this
the method should not be static to ensure thread-safety.
I was assuming that in scenario that you have
Am 28.04.2011 21:56, schrieb Xueming Shen:
That said, you do have the point, we should do better even in
malformed case, ...
Yes, that's what I wanted to point on.
But I thought, you could go 1 step further, declaring bb as member of UTF_8.Decoder. Then it should
be guaranteed, the a decoder
On 04/28/2011 01:55 PM, Ulf Zibis wrote:
Am 28.04.2011 21:56, schrieb Xueming Shen:
That said, you do have the point, we should do better even in
malformed case, ...
Yes, that's what I wanted to point on.
But I thought, you could go 1 step further, declaring bb as member of
UTF_8.Decoder.
Changeset: 7ae6c0fd479b
Author:jjg
Date: 2011-04-28 15:05 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7ae6c0fd479b
7029150: Project Coin: present union types from the tree API through to
javax.lang.model
Reviewed-by: mcimadamore
!
Am 28.04.2011 23:28, schrieb Xueming Shen:
On 04/28/2011 01:55 PM, Ulf Zibis wrote:
Am 28.04.2011 21:56, schrieb Xueming Shen:
That said, you do have the point, we should do better even in
malformed case, ...
Yes, that's what I wanted to point on.
But I thought, you could go 1 step further,
Thanks for the feedback. (but still waiting for the other one about static
methods)
-Ulf
Am 28.04.2011 19:38, schrieb Mike Duigou:
Essentially we ran out of time for this task and were confident enough in out
decision about the design and choice of names to go ahead. More discussion
didn't
Changeset: 6c8ae62463a3
Author:darcy
Date: 2011-04-28 17:51 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c8ae62463a3
7038843: IIOP serialization fails with NullPointerException when serializing
Throwable
Reviewed-by: dholmes, mchung
!
On 4/28/11 11:13 AM, Lance Andersen - Oracle wrote:
Hi all,
I could use a reviewer for 7040150 which addresses a positioning issue with
CacheResultSetImpl.removeCurrentRow().
The diff is located at:
http://cr.openjdk.java.net/~lancea/7040150/webrev.00/
The change in the index value looks
Changeset: 775b77e74bec
Author:sherman
Date: 2011-04-28 20:18 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/775b77e74bec
7037261: j.l.Character.isLowerCase/isUpperCase need to match the Unicode
Standard
Summary: updated j.l.c.lsLowerCase/isUpperCase
Reviewed-by: okutsu
!
25 matches
Mail list logo
