Re: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently

2011-06-23 Thread Mandy Chung
David, Thanks for taking a closer look. Really appreciate your detailed review. On 6/23/11 1:33 PM, David Holmes wrote: Sorry for the delay on this ... I concur with Mandy that using arrive() the thread must always be RUNNABLE or the expected next state. Hence the new check is ok. With the

Re: Code Review 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently

2011-06-23 Thread David Holmes
Chris Hegarty said the following on 06/23/11 20:22: On 06/23/11 06:33 AM, David Holmes wrote: Sorry for the delay on this ... I concur with Mandy that using arrive() the thread must always be RUNNABLE or the expected next state. Hence the new check is ok. Thanks David, With the new

hg: jdk8/tl/jdk: 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp

2011-06-23 Thread chris . hegarty
Changeset: 6b2c14dfe9b9 Author:chegar Date: 2011-06-23 13:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b2c14dfe9b9 7057935: com/sun/nio/sctp tests should be moved out of jdk_nio and into their own target, jdk_sctp Reviewed-by: alanb ! test/Makefile !

hg: jdk8/tl/jdk: 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently

2011-06-23 Thread chris . hegarty
Changeset: ae7211979179 Author:chegar Date: 2011-06-23 13:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae7211979179 7021010: java/lang/Thread/ThreadStateTest.java fails intermittently Reviewed-by: dholmes, alanb, mchung ! test/ProblemList.txt !

hg: jdk8/tl/jdk: 7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid jtreg tags

2011-06-23 Thread xuelei . fan
Changeset: cd7adb545f71 Author:xuelei Date: 2011-06-23 04:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd7adb545f71 7057022: test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java has invalid jtreg tags Reviewed-by: weijun !

hg: jdk8/tl/langtools: 7058174: Reduce langtools build warnings

2011-06-23 Thread jonathan . gibbons
Changeset: 18002d039806 Author:jjg Date: 2011-06-23 11:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/18002d039806 7058174: Reduce langtools build warnings Reviewed-by: jjg Contributed-by: alexandre.boulga...@oracle.com ! make/build.xml !

hg: jdk8/tl/jdk: 6253144: Long narrowing conversion should describe the algorithm used and implied risks

2011-06-23 Thread joe . darcy
Changeset: 151756a4037b Author:darcy Date: 2011-06-23 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/151756a4037b 6253144: Long narrowing conversion should describe the algorithm used and implied risks Reviewed-by: mduigou, alanb !

Re: Code review request for 6253144: Long narrowing conversion should describe the algorithm used and implied risks

2011-06-23 Thread joe . darcy
On 6/22/2011 8:52 AM, Chris Hegarty wrote: On 06/22/11 04:47 PM, Joe Darcy wrote: David Holmes wrote: Hi Joe, Joe Darcy said the following on 06/18/11 11:38: Please review this (somewhat tedious) change to make the behavior of the Number subtypes in the JDK more explicit: 6253144: Long

hg: jdk8/tl/jaxws: 18 new changesets

2011-06-23 Thread lana . steuck
Changeset: 6158298d2b94 Author:schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/6158298d2b94 Added tag jdk7-b144 for changeset 6bd683f2d527 ! .hgtags Changeset: c902e39c384e Author:jeff Date: 2011-05-27 15:01 -0700 URL:

hg: jdk8/tl/jaxp: 9 new changesets

2011-06-23 Thread lana . steuck
Changeset: bee49f47043f Author:schien Date: 2011-05-26 20:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/bee49f47043f Added tag jdk7-b144 for changeset 39bf6dcaab23 ! .hgtags Changeset: bdf77cbd9958 Author:ohair Date: 2011-05-19 08:38 -0700 URL:

hg: jdk8/tl/corba: 10 new changesets

2011-06-23 Thread lana . steuck
Changeset: 7033a5756ad5 Author:katleman Date: 2011-05-25 13:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/7033a5756ad5 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims !

hg: jdk8/tl/langtools: 27 new changesets

2011-06-23 Thread lana . steuck
Changeset: 8eb952f43b11 Author:katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8eb952f43b11 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims !

hg: jdk8/tl/jdk: 93 new changesets

2011-06-23 Thread lana . steuck
Changeset: 23bdcede4e39 Author:katleman Date: 2011-05-25 13:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23bdcede4e39 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims !