On 30/10/2013 23:43, Dan Xu wrote:
Hi All,
Here is a simple change to fix the test failure reported in
JDK-8027155. Due to the code change in JDK-8025128, this test also
needs to be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027155
Webrev:
Changeset: adab2c628923
Author:jlaskey
Date: 2013-10-29 14:22 -0300
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/adab2c628923
8027447: The wrong string buffer is specified for stderr in $EXEC
Reviewed-by: lagergren, sundar
Contributed-by: james.las...@oracle.com
!
Hi,
Please review the fix for JDK-8027470 below.
Description:
AnnotationSupport compared Class-instances using '==' where it should be using
'.equals'. Fixed in this patch.
Link to web review:
http://cr.openjdk.java.net/~alundblad/8027470
Link to bug reports:
Hi Andreas,
On 31/10/2013 7:49 PM, Andreas Lundblad wrote:
Hi,
Please review the fix for JDK-8027470 below.
Description:
AnnotationSupport compared Class-instances using '==' where it should be using
'.equals'. Fixed in this patch.
Class is final and does not override Object.equals
Changeset: 18c111c17231
Author:psandoz
Date: 2013-10-31 11:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18c111c17231
8027316: Distinct operation on an unordered stream should not be a barrier
Reviewed-by: henryjen, mduigou, briangoetz
!
Erik,
I have a build of ccache 3.1.9 on my Solaris box, but it is not being
used by the build as it thinks it is not greater than 3.1.4.
The suggested changes (below) are in line with the grep/regular
expression used in the GNU make version check you and Vinnie were
discussing yesterday.
While the change is correct, ccache usage on Solaris is pointless in my
experience. Are you actually seeing performance gains by using it? I
investigated this quite thoroghly a while back and concluded that ccache
and sun studio just didn't go together. I think I could make ccache work
with
Changeset: 9732816c9d17
Author:briangoetz
Date: 2013-10-29 12:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9732816c9d17
8024633: Lambda linkage performance - initialize generated class earlier
Reviewed-by: briangoetz, rfield
Contributed-by: sergey.kukse...@oracle.com
!
Changeset: 82ee370c3d7e
Author:briangoetz
Date: 2013-10-31 10:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82ee370c3d7e
8024637: Lambda linkage performance - use reflection instead of ASM to
manipulate parameter types
8023984: Lambda linkage performance - use a method
https://bugs.openjdk.java.net/browse/JDK-8022208
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.00/
The retry loop in checking the thread state assumes that the thread
state is in RUNNABLE state which isn't always the case (it could be any
other state). The fix
Anyone else beginning to get the sense that maybe some brainstorming for
a more sweeping/complete change to log manager initialization is
necessary? I suspect that these deadlocks and init order bugs are just
going to keep on coming, and every fix seems to add more complexity than
the last.
On 10/31/2013 11:01 AM, Martin Buchholz wrote:
+iterations++;
Using ++ on a volatile int looks racy. Using an AtomicInteger is
strictly more reliable.
Oh that's right. Will fix that. I don't really like duplicating the
code in these 2 tests and I am going to refactor
Hi Jeremy,
Thanks for reporting that.
Actually I'm not quite sure that drainLoggerRefQueueBounded() needs to
be synchronized on LogManager.
I'll need to study that - but my gut feeling is that we might
be able to get rid of that lock (possibly).
I'll have to study the call chain to see whether
On 10/31/2013 01:18 PM, Erik Joelsson wrote:
While the change is correct, ccache usage on Solaris is pointless in my
experience. Are you actually seeing performance gains by using it? I
When I originally got ccache hooked up I didn't see much ( if any )
improvement, but put this down to the
Updated webrev that has a new
test/lib/testlibrary/ThreadStateController.java and also change to use
AtomicInteger:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/
Mandy
On 10/31/2013 11:22 AM, Mandy Chung wrote:
On 10/31/2013 11:01 AM, Martin Buchholz wrote:
+
Changeset: e93de88661ab
Author:dxu
Date: 2013-10-31 11:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e93de88661ab
8027155: test/java/io/File/NulFile.java failing when test run in othervm mode
Reviewed-by: mchung, alanb
! test/java/io/File/NulFile.java
On 31/10/2013 19:11, Mandy Chung wrote:
Updated webrev that has a new
test/lib/testlibrary/ThreadStateController.java and also change to use
AtomicInteger:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/
Mandy
Is ThreadStateController general enough for the unname package
A quick fix to remove path for the temporary output file so that it's
created in the working directory instead:
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
Thanks,
Joe
On 10/30/2013 1:33 PM, John Rose wrote:
8024635: Caching MethodType's descriptor string improves lambda linkage
performance
Summary: Better interpreted and compiled performance of operations in
MethodType important to LambdaMetafactory.
Reviewed-by: jrose, twisti, ?
Contributed-by: skuksenko
Looks ok to me.
-Chris.
On 10/31/2013 07:54 PM, huizhe wang wrote:
A quick fix to remove path for the temporary output file so that it's
created in the working directory instead:
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
Thanks,
Joe
On Oct 31, 2013, at 1:05 PM, Mandy Chung mandy.ch...@oracle.com wrote:
Nit: maybe better to merge two constructors to explicitly specify if it wants
to skip the parameter validations (not sure if there is any reason for the
rtype and ptypes parameter order is different in the two ctors)
On 10/31/2013 12:34 PM, Alan Bateman wrote:
On 31/10/2013 19:11, Mandy Chung wrote:
Updated webrev that has a new
test/lib/testlibrary/ThreadStateController.java and also change to
use AtomicInteger:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/
Mandy
Is
On 10/31/2013 1:38 PM, John Rose wrote:
On Oct 31, 2013, at 1:05 PM, Mandy Chung mandy.ch...@oracle.com
mailto:mandy.ch...@oracle.com wrote:
Nit: maybe better to merge two constructors to explicitly specify if
it wants to skip the parameter validations (not sure if there is any
reason for
Changeset: c4bbd5963f9c
Author:joehw
Date: 2013-10-31 13:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4bbd5963f9c
8024876: [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed
when testbase dir has read only permissions
Reviewed-by: chegar
!
Hi,
1. JDK-8027227, updates the internal ASM code base, for fixes made by
ASM team
for JSR-335 byte code compliance
http://cr.openjdk.java.net/~ksrini/8027227/webrev.0/
2. JDK-8027232, updates the java/lang/invoke and lambda classes for
JSR-335 byte
code compliance.
Hi Mandy,
On 1/11/2013 5:11 AM, Mandy Chung wrote:
Updated webrev that has a new
test/lib/testlibrary/ThreadStateController.java and also change to use
AtomicInteger:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/
Sorry but I don't see how this works - and that applies to
On 10/31/2013 5:38 PM, David Holmes wrote:
Hi Mandy,
On 1/11/2013 5:11 AM, Mandy Chung wrote:
Updated webrev that has a new
test/lib/testlibrary/ThreadStateController.java and also change to use
AtomicInteger:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8022208/webrev.01/
Sorry but I
27 matches
Mail list logo
