Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2013-12-20 Thread Chris Hegarty
On 20 Dec 2013, at 04:33, Mandy Chung mandy.ch...@oracle.com wrote: Hi Srikalyan, Maybe you can get add an uncaught handler to see if you can get any information. +1. With this, at least the next time we see this failure we should have a better idea where the OOM is coming from.

Re: RFR of lang level code migration patches

2013-12-20 Thread Paul Sandoz
On Dec 19, 2013, at 5:44 PM, Brian Goetz brian.go...@oracle.com wrote: +1 on all changes, except perhaps for this one in Collections.copy: ListIterator? super T di=dest.listIterator(); ListIterator? extends T si=src.listIterator(); for (int i=0; isrcSize; i++) {

Re: i18n dev RFR: 8025051: Update resource files for TimeZone display names

2013-12-20 Thread Aleksej Efimov
Masayoshi, Thank you for the detailed review and your comments. I tried to address all of them. The responses are below. The new webrev can be found here: http://cr.openjdk.java.net/~aefimov/8025051/8/webrev.01/ http://cr.openjdk.java.net/%7Eaefimov/8025051/8/webrev.01/ Michael, As Masayoshi

Re: RFR: JDK-8028712 : Tidy warnings cleanup for java.sql package

2013-12-20 Thread Serge
Hi all. Please review a second fix http://cr.openjdk.java.net/~yan/8028712/webrev.03/ for https://bugs.openjdk.java.net/browse/JDK-8028712 I deleted part of java/sql/package.html, and replaced br/ to br for compliance with html 3.2 On 12/05/2013 10:39 PM, Lance Andersen - Oracle wrote: Hi

Re: RFR for JDK-6963118 Intermittent test failure: test/java/nio/channels/Selector/Wakeup.java fail intermittently (win)

2013-12-20 Thread Alan Bateman
On 20/12/2013 04:18, David Holmes wrote: : Increasing the timeouts seems okay but how confident are you that this is sufficient for a wide range of platforms. In other tests we often see timeouts of a few seconds get extended even further, so three seconds is not so big. Also the yield

Re: Bug in Long.parseUnsignedLong

2013-12-20 Thread Paul Sandoz
Hi Brian, It would be nice to avoid the caches, on a hunch i am wondering if the following will work: long result = first * radix + second; if ((first 1) (Long.MAX_VALUE / radix) || // possible overflow of first * radix Long.compareUnsigned(result, first) 0) { // overflow of

Re: Bug in Long.parseUnsignedLong

2013-12-20 Thread Dmitry Nadezhin
What is performance of Long.compareUnsigned(x, y) ? Does HotSpot implement it as a call of Long.compare(x + MIN_VALUE, y + MIN_VALUE) or as a single machine instruction ? On Fri, Dec 20, 2013 at 7:53 PM, Paul Sandoz paul.san...@oracle.com wrote: Hi Brian, It would be nice to avoid the

Re: Demo for Parallel Core Collection API

2013-12-20 Thread Paul Sandoz
Hi Tristan, Thanks, I need to look at this in more detail, but here are some quick comments. - recommend you try and avoid using limit with parallel ops, for example the Pi example cam be reformulated as: long M = LongStream.range(0, N).parallel().filter(sr - { double x =

hg: jdk8/tl/jdk: 8029955: AIOB in XMLEntityScanner.scanLiteral upon parsing literals with 100 LF chars

2013-12-20 Thread huizhe . wang
Changeset: 73473e9dfc46 Author:joehw Date: 2013-12-20 09:56 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/73473e9dfc46 8029955: AIOB in XMLEntityScanner.scanLiteral upon parsing literals with 100 LF chars Reviewed-by: dfuchs, lancea, ulfzibis +

Re: RFR for JDK-6772009 Intermittent test failure: java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java test failed with 'Completed != 2'

2013-12-20 Thread srikalyan
Hi David, i retained only the changes to ITERS, ProbleMList.txt and upstream changes by Doug Lea(as pointed by Martin), could you please review the new change available here http://cr.openjdk.java.net/~srikchan/Regression/6772009-CancelledLockLoop-webrev/ . -- Thanks kalyan Ph:

hg: jdk8/tl/jdk: 2 new changesets

2013-12-20 Thread roger . riggs
Changeset: 7186275e6ef1 Author:rriggs Date: 2013-12-20 13:06 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7186275e6ef1 8030002: Enhance deserialization using readObject Reviewed-by: sherman, chegar, scolebourne ! src/share/classes/java/time/Duration.java !

JDK 9 RFR of JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount

2013-12-20 Thread Joe Darcy
Hello, Please review the patch below to fix JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount The Executable type was added in 8 so none of the method in Executable should have an @since 1.8 tag. In the Constructor and Executable subtypes, @since

RFR: 8030850: Setting .level=FINEST for the root logger in logging configuration file doesn't work

2013-12-20 Thread Daniel Fuchs
Hi, Please find below a fix for 8030850: Setting .level=FINEST for the root logger in logging configuration file doesn't work https://bugs.openjdk.java.net/browse/JDK-8030850 http://cr.openjdk.java.net/~dfuchs/webrev_8030850/webrev.00/ This is a regression I introduced with my fix

Re: RFR: 8030850: Setting .level=FINEST for the root logger in logging configuration file doesn't work

2013-12-20 Thread Mandy Chung
On 12/20/2013 10:45 AM, Daniel Fuchs wrote: Hi, Please find below a fix for 8030850: Setting .level=FINEST for the root logger in logging configuration file doesn't work https://bugs.openjdk.java.net/browse/JDK-8030850 http://cr.openjdk.java.net/~dfuchs/webrev_8030850/webrev.00/

Re: JDK 9 RFR of JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount

2013-12-20 Thread Mike Duigou
+1 Mike On Dec 20 2013, at 10:29 , Joe Darcy joe.da...@oracle.com wrote: Hello, Please review the patch below to fix JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount The Executable type was added in 8 so none of the method in Executable should

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2013-12-20 Thread srikalyan
Hi Mandy, yes I ran with JTreg to simulate the failure, i will try the UEH patch to see if it sheds some light and get back to you. Thanks for the direction :) -- Thanks kalyan Ph: (408)-585-8040 On 12/19/13, 8:33 PM, Mandy Chung wrote: Hi Srikalyan, Maybe you can get add an uncaught

Re: JDK 9 RFR of JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount

2013-12-20 Thread Mandy Chung
--- a/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 08:59:52 2013 -0800 +++ b/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 10:26:17 2013 -0800 @@ -251,7 +251,8 @@ } /** - * {@inheritDoc} + * {@inheritDoc}1 Is this accident? Other than this,

Re: JDK 9 RFR of JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount

2013-12-20 Thread Joe Darcy
On 12/20/2013 01:21 PM, Mandy Chung wrote: --- a/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 08:59:52 2013 -0800 +++ b/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 10:26:17 2013 -0800 @@ -251,7 +251,8 @@ } /** - * {@inheritDoc} + *

RFR: jdk9: 8029997: [infra] remove Solaris ISA directories and the links

2013-12-20 Thread Kumar Srinivasan
Hello, Please review the removal of ISA (Instruction Specific Architecture) directories namely sparcv9, amd64 and the symlinks in these directories, this was provided to aid transition to jdk8, where solaris 32-bit was removed, and the 32-bit binaries were replaced with 64-bit versions.

Re: RFR: jdk9: 8029997: [infra] remove Solaris ISA directories and the links

2013-12-20 Thread Tim Bell
Hi Kumar: Please review the removal of ISA (Instruction Specific Architecture) directories namely sparcv9, amd64 and the symlinks in these directories, this was provided to aid transition to jdk8, where solaris 32-bit was removed, and the 32-bit binaries were replaced with 64-bit versions.

Re: JDK 9 RFR of JDK-8030785: Missing since 1.8 javadoc for java.lang.reflect.Method:getParameterCount

2013-12-20 Thread Stuart Marks
On 12/20/13 2:03 PM, Joe Darcy wrote: On 12/20/2013 01:21 PM, Mandy Chung wrote: --- a/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 08:59:52 2013 -0800 +++ b/src/share/classes/java/lang/reflect/Method.javaFri Dec 20 10:26:17 2013 -0800 @@ -251,7 +251,8 @@ } /** -

Re: RFR for JDK-7168267: TEST_BUG: Cleanup of rmi regression tests (activation and others)

2013-12-20 Thread Stuart Marks
Hi Tristan, Thanks for cleaning this up. I've gone ahead and pushed the revised changeset. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/eaa533e9778a I did take the liberty of making a couple changes... first, I had to fix some whitespace issues (trailing whitespace on a line) that were caught

Re: RFR for JDK-8030284 TEST_BUG: intermittent StackOverflow in RMI bench/serial test

2013-12-20 Thread Stuart Marks
On 12/19/13 8:29 PM, David Holmes wrote: If you were always one frame from the end then it is not so surprising that a simple change pushes you past the limit :) Try running the shell test with additional recursive loads and see when it fails. David doesn't seem surprised, but I guess I still

Re: RFR for JDK-8030057: speed up forceLogSnapshot and checkAnnotations

2013-12-20 Thread Stuart Marks
Hi Tristan, First of all, these are two completely separate changes. They're sort-of related in that they involve replacing sleep() loops and polling with different constructs, but other than that, they're completely independent. As you'll see from my review comments, there are different

Re: RFR for JDK-6772009 Intermittent test failure: java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java test failed with 'Completed != 2'

2013-12-20 Thread David Holmes
On 21/12/2013 4:19 AM, srikalyan wrote: Hi David, i retained only the changes to ITERS, ProbleMList.txt and upstream changes by Doug Lea(as pointed by Martin), could you please review the new change available here http://cr.openjdk.java.net/~srikchan/Regression/6772009-CancelledLockLoop-webrev/