Re: RFR for JDK-7027502: Test failures in demo/jvmti/hprof testcases, need to be othervm

2014-01-13 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 13 jan 2014, at 07:21, Tristan Yan tristan@oracle.com wrote: Hi All I add more trace output to track down possible reason of this failure. Please help to review it again. http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.05/ Thank you Tristan On

Re: RFR 8030848: Collections.sort(List l, Comparator) should defer to List.sort(Comparator )

2014-01-13 Thread Paul Sandoz
On Jan 10, 2014, at 6:56 PM, Mike Duigou mike.dui...@oracle.com wrote: The implementation looks good. I would move construction of the listIterator to before the toArray() for detection of concurrent modification (growing of the list). If there is another thread concurrently operating on

Doc updates was Re: RFR 8030848: Collections.sort(List l, Comparator) should defer to List.sort(Comparator )

2014-01-13 Thread Paul Sandoz
On Jan 10, 2014, at 3:01 PM, Alan Bateman alan.bate...@oracle.com wrote: The implementation changes look good. I agree that the javadoc needs changing as it's otherwise misleading as to what the implementation actually does. I would think that this should go with the implementation change

Review request for JDK-8027908

2014-01-13 Thread Iaroslav Savytskyi
Hi, I have created new fix version for https://bugs.openjdk.java.net/browse/JDK-8027908 Fix: From the previous discussion I’ve choosen 3rd option - to add SUID. Webrev: http://cr.openjdk.java.net/~mkos/8027908/webrev.01/ Thanks. — Best regards, Iaroslav On 11 Jan 2014, at 17:41, Alan

Re: Review request for JDK-8027908

2014-01-13 Thread Alan Bateman
On 13/01/2014 15:00, Iaroslav Savytskyi wrote: Hi, I have created new fix version for https://bugs.openjdk.java.net/browse/JDK-8027908 Fix: From the previous discussion I’ve choosen 3rd option - to add SUID. Webrev: http://cr.openjdk.java.net/~mkos/8027908/webrev.01/ Good! Do you have a

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
Hi Alan, Chris, On 11/01/2014 00:55, Kumar Srinivasan wrote: Hi, Please review fixes for launcher correctness wrt. JNI calls. http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/ Looks okay, the only thing that isn't clear is whether the calls to the static methods defined by the launcher

hg: jdk8/tl/jaxws: 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed

2014-01-13 Thread alan . bateman
Changeset: bd943bdbce05 Author:alanb Date: 2014-01-13 16:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/bd943bdbce05 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed Reviewed-by: alanb Contributed-by: iaroslav.savyts...@oracle.com

Re: Review request for JDK-8027908

2014-01-13 Thread Iaroslav Savytskyi
Hi, Alan, Miroslav told me to send such text block. ——— 8027908: Serialization of the j.x.b.TypeConstraintException is incompatible starts from the jdk8b112 Reviewed-by: alanb Contributed-by: iaroslav.savyts...@oracle.com —— On 13 Jan 2014, at 16:29, Alan Bateman alan.bate...@oracle.com

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
As for the launcher helper calls, they all call abort/System.exit and bale out, they are also guarded by ExceptionOccurred in the native-land. Here is the updated version: The delta webrev since the last reviewed changes:

Review request for 6516909: (cl spec) ClassLoader.loadClass() clarification to indicate it shouldn't be used for array classes

2014-01-13 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/6516909/webrev.00/ This patch is to fix: 6516909: (cl spec) ClassLoader.loadClass() clarification to indicate it shouldn't be used for array classes 4932272: (cl) Remove declaration of the unused private method ClassLoader.defineClass0

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Mandy Chung
On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that has no return value? It's fine with me if you want to

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-13 Thread srikalyan
On 1/11/14, 6:15 AM, Peter Levart wrote: On 01/10/2014 10:51 PM, srikalyan chandrashekar wrote: Hi Peter the version you provided ran indefinitely(i put a 10 minute timeout) and the program got interrupted(no error), Did you run it with or without fastedbug -XX:+TraceExceptions ? If with,

JEP 187: Serialization 2.0

2014-01-13 Thread mark . reinhold
Posted: http://openjdk.java.net/jeps/187 - Mark

JDK 9 RFR of JDK-8031651: Remove unneeded -source and -target flags in jdk repo regression tests

2014-01-13 Thread Joe Darcy
Hello, Per the policy set forth in JEP 182: Policy for Retiring javac -source and -target Options http://openjdk.java.net/jeps/182 in JDK 9, javac will only recognize javac source and target value of 6/1.6 and higher. Therefore, uses of earlier options in the JDK regression tests

Re: JDK 9 RFR of JDK-8031651: Remove unneeded -source and -target flags in jdk repo regression tests

2014-01-13 Thread Joe Darcy
Thanks Martin; I'll remove the java/util/concurrent/* files from my patch. -Joe On 01/13/2014 06:30 PM, Martin Buchholz wrote: All occurrences of @compile -source 1.5 have been removed from jsr166 CVS. On Mon, Jan 13, 2014 at 5:11 PM, Joe Darcy joe.da...@oracle.com

Re: RFR for JDK-7027502: Test failures in demo/jvmti/hprof testcases, need to be othervm

2014-01-13 Thread David Holmes
On 13/01/2014 4:21 PM, Tristan Yan wrote: Hi All I add more trace output to track down possible reason of this failure. Please help to review it again. http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.05/ You seem to have dragged in some unrelated changes to ProblemList.txt Also I don't

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Kumar Srinivasan
Mandy, On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that has no return value? It's fine with me if you

Re: RFR: (8030875) Macros for checking and returning on exceptions

2014-01-13 Thread David Holmes
Hi Roger, On 11/01/2014 1:37 AM, roger riggs wrote: Please review: To enable native code checking consistently for thrown exceptions, the macros in net_util.h and java/util/jar/pack/coding.cpp are made consolidated and promoted to jni_util.h webrev:

Re: 8031494: [launcher] java launcher should check for JNI Pending exceptions.

2014-01-13 Thread Mandy Chung
On 1/13/2014 6:35 PM, Kumar Srinivasan wrote: Mandy, On 1/13/2014 2:44 PM, Kumar Srinivasan wrote: The full webrev: http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/ This looks good. Should it also check if there is any pending exception after the call to CallStaticVoidMethod that