Re: RFR(S/L): 8028537: PPC64: Updated the JDK regression tests to run on AIX

2014-01-17 Thread Alan Bateman
On 15/01/2014 16:42, Volker Simonis wrote: Hi Alan, thanks for the suggestion. That's fine for me. I've copied the empty SCTP stubs from the macosx to the aix directory as well and updated the make file accordingly (in the patch for 8031581: PPC64: Addons and fixes for AIX to pass the jdk

Re: JDK8 RFR JDK-8029237 Update copyright year to match last edit in jdk8 jaxws repository for 2013

2014-01-17 Thread Miroslav Kos
Hi Steve and Alan, I just reminding this issue - I have no response from anybody yet and it would really simplify our integration if I could handle copyright years inconsistencies this way - I see this issue in many jdk branches and these each-branch-different changes make each integration

RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Volker Simonis
Hi, could you please review the following change which makes the various POLL constants used in sun.nio.ch platform dependant: http://cr.openjdk.java.net/~simonis/webrevs/8031997/ These changes are currently targeted for the ppc-aix-port/stage-9 repository but it is planned to merge them soon

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Alan Bateman
On 17/01/2014 11:25, Volker Simonis wrote: : I've compiled and smoke-tested the changes on Linux/x86_64/PPC64, Windows/x86_64, Solaris/SPARC, MacOS X and AIX. On all these platforms they pass all the java/nio JTREG tests in the same way like without this change. This means that on Linux/MacOS

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-17 Thread Peter Levart
On 01/17/2014 05:38 AM, David Holmes wrote: On 17/01/2014 1:31 PM, srikalyan chandrashekar wrote: Hi David, the disassembled code is also attached to the bug. Per my Sorry missed that. analysis the exception was thrown when Reference Handler was on line 143 as put in the earlier email.

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-17 Thread Peter Levart
On 01/17/2014 02:00 PM, Peter Levart wrote: On 01/17/2014 05:38 AM, David Holmes wrote: On 17/01/2014 1:31 PM, srikalyan chandrashekar wrote: Hi David, the disassembled code is also attached to the bug. Per my Sorry missed that. analysis the exception was thrown when Reference Handler was

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Florian Weimer
On 01/17/2014 12:25 PM, Volker Simonis wrote: To avoid a mapping of the Java constants to the native ones every time we go from Java to Native and back, this change replaces the currently used constants with a single instance of constants which is placed in src/share/classes/sun/nio/ch/Net.java

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-17 Thread Peter Levart
On 01/17/2014 02:13 PM, Peter Levart wrote: // Fast path for cleaners boolean isCleaner = false; try { isCleaner = r instanceof Cleaner; } catch (OutofMemoryError oome) { continue; } if (isCleaner) { ((Cleaner)r).clean(); continue; } Hi David, Kalyan, I've caught-up now. Just

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Volker Simonis
On Fri, Jan 17, 2014 at 12:44 PM, Alan Bateman alan.bate...@oracle.com wrote: On 17/01/2014 11:25, Volker Simonis wrote: : I've compiled and smoke-tested the changes on Linux/x86_64/PPC64, Windows/x86_64, Solaris/SPARC, MacOS X and AIX. On all these platforms they pass all the java/nio

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Volker Simonis
On Fri, Jan 17, 2014 at 2:23 PM, Florian Weimer fwei...@redhat.com wrote: On 01/17/2014 12:25 PM, Volker Simonis wrote: To avoid a mapping of the Java constants to the native ones every time we go from Java to Native and back, this change replaces the currently used constants with a single

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Florian Weimer
On 01/17/2014 03:04 PM, Volker Simonis wrote: On Fri, Jan 17, 2014 at 2:23 PM, Florian Weimer fwei...@redhat.com wrote: On 01/17/2014 12:25 PM, Volker Simonis wrote: To avoid a mapping of the Java constants to the native ones every time we go from Java to Native and back, this change replaces

JDK 9 RFR for 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281

2014-01-17 Thread Daniel Fuchs
Hi, Please find below a webrev for: 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281 https://bugs.openjdk.java.net/browse/JDK-8031980 http://cr.openjdk.java.net/~dfuchs/webrev_8031980/webrev.00/ Thread dumps that were sent to me after recent sighting of JDK-8027670 have

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Alan Bateman
On 17/01/2014 13:45, Volker Simonis wrote: : Yes, you're right - it was because of a VirtualBox Host-Only Network network device which seems to fool the test. After I disabled it, all tests passed successfully! And what about the change itself :) The change itself looks mostly okay. For

Re: RFR(S/L): 8028537: PPC64: Updated the JDK regression tests to run on AIX

2014-01-17 Thread Alan Bateman
On 14/01/2014 16:57, Volker Simonis wrote: Hi, could you please review the following change: http://cr.openjdk.java.net/~simonis/webrevs/8028537/ which, together with the changes from 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests and 8031134 : PPC64: implement

RFR: JDK-8031373 and 8030079 -- lint warnings in java.util.stream and java.lang.invoke

2014-01-17 Thread Brian Goetz
Webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8031373/webrev/ If someone with ASM fu (Remi?) could sanity check the JLI changes, that would be appreciated.

Re: RFR: JDK-8031373 and 8030079 -- lint warnings in java.util.stream and java.lang.invoke

2014-01-17 Thread Paul Sandoz
On Jan 17, 2014, at 5:09 PM, Brian Goetz brian.go...@oracle.com wrote: Webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8031373/webrev/ If someone with ASM fu (Remi?) could sanity check the JLI changes, that would be appreciated. Stream code looks good. I notice some other

Re: RFR: JDK-8031373 and 8030079 -- lint warnings in java.util.stream and java.lang.invoke

2014-01-17 Thread Remi Forax
On 01/17/2014 05:42 PM, Paul Sandoz wrote: On Jan 17, 2014, at 5:09 PM, Brian Goetz brian.go...@oracle.com wrote: Webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8031373/webrev/ If someone with ASM fu (Remi?) could sanity check the JLI changes, that would be appreciated. Stream

Re: RFR(S/L): 8028537: PPC64: Updated the JDK regression tests to run on AIX

2014-01-17 Thread Volker Simonis
Hi Alan, thanks for looking at this. Please find may comments inline: On Fri, Jan 17, 2014 at 10:48 AM, Alan Bateman alan.bate...@oracle.com wrote: On 15/01/2014 16:42, Volker Simonis wrote: Hi Alan, thanks for the suggestion. That's fine for me. I've copied the empty SCTP stubs from the

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

2014-01-17 Thread Volker Simonis
On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman alan.bate...@oracle.com wrote: On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and

Re: RFR(M): 8031997: PPC64: Make the various POLL constants system dependant

2014-01-17 Thread Alan Bateman
On 17/01/2014 17:42, Volker Simonis wrote: : Here's the new webrev: http://cr.openjdk.java.net/~simonis/webrevs/8031997_2/ Built and tested like before. Everything OK. Is this now ready for push into ppc-aix-port/stage-9? Thanks the updates, this looks good to me. -Alan.

Re: RFR(S/L): 8028537: PPC64: Updated the JDK regression tests to run on AIX

2014-01-17 Thread Alan Bateman
On 17/01/2014 21:10, Volker Simonis wrote: : Done. Moved the excluded tests down to the jdk_jmx section. Here's the new webrev: http://cr.openjdk.java.net/~simonis/webrevs/8028537_2/ Can I push this now to ppc-aix-port/stage-9? The SBC change looks good. I can't see the move of the excluded