Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread David Holmes
On 21/01/2014 4:54 PM, Peter Levart wrote: On 01/21/2014 03:22 AM, David Holmes wrote: Hi Peter, I do not see Cleaner being loaded prior to the main class on either Windows or Linux. Which platform are you on? Did you see it loaded before the main class or as part of executing it? Before. Th

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-21 Thread Paul Sandoz
On Jan 20, 2014, at 11:16 PM, Alan Bateman wrote: > On 20/01/2014 10:38, Paul Sandoz wrote: >> Hi, >> >> For the flatMap operations of streams we forgot to say what it does with the >> mapped streams after it has processed them i.e. closes them, which is >> important for I/O backed streams (e

RFR: 8030822: (tz) Support tzdata2013i

2014-01-21 Thread Aleksej Efimov
Hi, Can I have a review for 2013i timezone data integration [1] to JDK9. There is one change in tzdb that affects naming for "Asia/Amman" timezone: "The Jordan switches back to standard time at 00:00 on December 20, 2013." All changes in TimeZoneNames*.java and TimeZoneNames*.properties files

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread Peter Levart
Hi, David, Kalyan, Summing up the discussion, I propose the following patch for ReferenceHandler: http://cr.openjdk.java.net/~plevart/jdk9-dev/OOMEInReferenceHandler/webrev.01/ all 10 java/lang/ref tests pass on my PC (including OOMEInReferenceHandler). I kindly ask Kalyan to try to re-run t

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread Peter Levart
On 01/21/2014 08:57 AM, David Holmes wrote: [Loaded java.util.TimeZone from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar] [Loaded sun.util.calendar.ZoneInfo from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar] [Loaded sun.util.calendar.ZoneInfoFile from /home/peter/Apps64/jdk1.8.0-ea-b1

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread Peter Levart
On 01/21/2014 07:54 AM, Peter Levart wrote: *[Loaded sun.misc.Cleaner from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar]* [Loaded java.io.ByteArrayInputStream from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar] [Loaded sun.util.calendar.ZoneInfoFile$ZoneOffsetTransitionRule from /hom

Re: JDK9 RFR of JDK-8029646: [pack200] should support the new zip64 format.

2014-01-21 Thread Kumar Srinivasan
Alex, Thanks for adding the test, few comments: PackTestZip64.java: 1. compareTwoFile, I would read the entire file into ByteArrayInputStream, compare the total first ie. fast fail, but what you have is also ok. 2. generateLargeJar: I would replace lines 126,127 and 128 using for-each loop

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread srikalyan
Hi Peter/David, catching up after long weekend. Why would there be an OOME in object heap due to class loading in perm gen space ? Please correct if i am missing something here. Meanwhile i will give the version of Reference Handler you both agreed on a try. -- Thanks kalyan Ph: (408)-585-8040

JDK 9 RFR of 8032397: Remove sun.misc.Ref

2014-01-21 Thread Joe Darcy
Hello, Following up from an earlier discussion on core-libs [1], I've gone through the exercise of purging sun.misc.Ref from the JDK repo. Patch below (having difficulties uploading the webrev to cr.openjdk at the time of writing.) For the change associated with removing sun.misc.Ref, I was

hg: jdk8/tl: 5 new changesets

2014-01-21 Thread lana . steuck
Changeset: ca4612164195 Author:lana Date: 2014-01-08 11:36 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ca4612164195 Merge Changeset: b5e1dad69605 Author:jeff Date: 2014-01-13 14:41 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b5e1dad69605 7129980: Third

hg: jdk8/tl/langtools: 6 new changesets

2014-01-21 Thread lana . steuck
Changeset: d5aab8300d3b Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d5aab8300d3b Added tag jdk8-b123 for changeset a345cf28faca ! .hgtags Changeset: 4a5e16002234 Author:lana Date: 2014-01-08 11:39 -0800 URL: htt

hg: jdk8/tl/nashorn: 4 new changesets

2014-01-21 Thread lana . steuck
Changeset: 3356919b1639 Author:jeff Date: 2014-01-13 14:45 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3356919b1639 7129980: Third Party License Readme update for JDK8 Reviewed-by: lana, tbell ! THIRD_PARTY_README Changeset: aefba9e5e35c Author:lana Date: 20

hg: jdk8/tl/hotspot: 10 new changesets

2014-01-21 Thread lana . steuck
Changeset: c89630a122b4 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c89630a122b4 Added tag jdk8-b123 for changeset 591135a7d6f9 ! .hgtags Changeset: f898fdfc08a5 Author:jeff Date: 2014-01-13 14:42 -0800 URL: http:

hg: jdk8/tl/jaxp: 5 new changesets

2014-01-21 Thread lana . steuck
Changeset: 1a28f773c894 Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1a28f773c894 Added tag jdk8-b123 for changeset 4e35b5b6d2e5 ! .hgtags Changeset: d906d69e24a3 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http://h

hg: jdk8/tl/corba: 5 new changesets

2014-01-21 Thread lana . steuck
Changeset: afecd2878aee Author:katleman Date: 2014-01-10 08:31 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/afecd2878aee Added tag jdk8-b123 for changeset 1ecd4619f60c ! .hgtags Changeset: b509e2e0fc41 Author:jeff Date: 2014-01-13 14:42 -0800 URL: http://

hg: jdk8/tl/jdk: 8 new changesets

2014-01-21 Thread lana . steuck
Changeset: 9683419eddef Author:lana Date: 2014-01-08 11:39 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9683419eddef Merge Changeset: 2551e7290450 Author:jeff Date: 2014-01-13 14:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2551e7290450 7129980

hg: jdk8/tl/jaxws: 5 new changesets

2014-01-21 Thread lana . steuck
Changeset: 241e4effed6d Author:katleman Date: 2014-01-10 08:32 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/241e4effed6d Added tag jdk8-b123 for changeset 91f5c542ccad ! .hgtags Changeset: c71b6b41a2a1 Author:jeff Date: 2014-01-13 14:43 -0800 URL: http://

Re: [JDK8] RFR (XS): JSR292: IncompatibleClassChangeError in LambdaForm for CharSequence.toString() method handle type converter

2014-01-21 Thread John Rose
On Jan 15, 2014, at 6:49 PM, Christian Thalinger wrote: > John would know the answer. > > Given this change should go into JDK 8 I think we should push for now. If we > can come up with a better way to handle these situations we can push another > change for 9 or 8u20. (Back from vacation.)

Re: RFR: 8032190 It's unclear that flatMap will ensure each stream will be closed.

2014-01-21 Thread Mike Duigou
On Jan 20 2014, at 07:18 , Paul Sandoz wrote: > > On Jan 20, 2014, at 3:18 PM, Chris Hegarty wrote: > >> It is good to clarify that the streams are closed. >> >> I find the following updated wording a little odd, "If a mapped stream is >> {@code null} then it treated as if it was an empty s

Re: JDK 9 RFR of 8032397: Remove sun.misc.Ref

2014-01-21 Thread Alan Bateman
On 21/01/2014 18:28, Joe Darcy wrote: Hello, Following up from an earlier discussion on core-libs [1], I've gone through the exercise of purging sun.misc.Ref from the JDK repo. Patch below (having difficulties uploading the webrev to cr.openjdk at the time of writing.) For the change associ

Re: JDK 9 RFR of 8032397: Remove sun.misc.Ref

2014-01-21 Thread Joe Darcy
PS Webrev now posted at: http://cr.openjdk.java.net/~darcy/8032397.0/ -Joe On 01/21/2014 10:28 AM, Joe Darcy wrote: Hello, Following up from an earlier discussion on core-libs [1], I've gone through the exercise of purging sun.misc.Ref from the JDK repo. Patch below (having difficulties

Re: JDK 9 RFR of 8032397: Remove sun.misc.Ref

2014-01-21 Thread Joe Darcy
Hi Alan, On 01/21/2014 01:02 PM, Alan Bateman wrote: On 21/01/2014 18:28, Joe Darcy wrote: Hello, Following up from an earlier discussion on core-libs [1], I've gone through the exercise of purging sun.misc.Ref from the JDK repo. Patch below (having difficulties uploading the webrev to cr.op

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread Peter Levart
On 01/21/2014 07:17 PM, srikalyan wrote: Hi Peter/David, catching up after long weekend. Why would there be an OOME in object heap due to class loading in perm gen space ? The perm gen is not a problem her (JDK 8 does not have it and we see OOME on JDK8 too). Each time a class is loaded, new

Re: RFR: JDK-8032012, , String.toLowerCase/toUpperCase performance improvement

2014-01-21 Thread Xueming Shen
Hi Paul, thanks for reviewing the changeset, comment inlined below. On 01/20/2014 09:24 AM, Paul Sandoz wrote: Some quick comments. In String.toLowerCase: - it would be nice to get rid of the pseudo goto using the "scan" labelled block. webrev has been updated to remove the pseudo goto by

Move forward for JDK-8029891

2014-01-21 Thread Tristan Yan
Hi Mandy We have discussed bug https://bugs.openjdk.java.net/browse/JDK-8029891 in JBS. And we don't think this is a good time to fix it. I suggest we do two things for this bug if it's okay for you. 1. We open a new JDK bug for tracking down future JDK change. Also link JDK-8029891 to this new

Re: Move forward for JDK-8029891

2014-01-21 Thread Mandy Chung
Hi Tristan, On 1/21/2014 4:26 PM, Tristan Yan wrote: Hi Mandy We have discussed bug https://bugs.openjdk.java.net/browse/JDK-8029891 in JBS. And we don't think this is a good time to fix it. I suggest we do two things for this bug if it's okay for you. 1. We open a new JDK bug for tracking do

Re: Move forward for JDK-8029891

2014-01-21 Thread Tristan Yan
Thank you Mandy If you want to fix it soon. I am okay to use this bug as the one tracking the fix. BTW This is an intermittent failure. Regards Tristan On Jan 22, 2014, at 8:52 AM, Mandy Chung wrote: > Hi Tristan, > > On 1/21/2014 4:26 PM, Tristan Yan wrote: >> Hi Mandy >> >> We have discusse

Re: JDK 9 RFR of 8032397: Remove sun.misc.Ref

2014-01-21 Thread Joe Darcy
Hi Alan, Updated webrev at http://cr.openjdk.java.net/~darcy/8032397.1/ @see in sun.misc.Ref removed. Regression tests updated to not refer to sun.misc.Ref. I looked at the use of Ref in jhat and it is only used if java.lang.ref.Reference is not found reflectively, so I think the existi

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread David Holmes
On 22/01/2014 1:24 AM, Peter Levart wrote: On 01/21/2014 07:54 AM, Peter Levart wrote: *[Loaded sun.misc.Cleaner from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar]* [Loaded java.io.ByteArrayInputStream from /home/peter/Apps64/jdk1.8.0-ea-b121/jre/lib/rt.jar] [Loaded sun.util.calendar.ZoneI

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread David Holmes
On 22/01/2014 8:31 AM, Peter Levart wrote: On 01/21/2014 07:17 PM, srikalyan wrote: Hi Peter/David, catching up after long weekend. Why would there be an OOME in object heap due to class loading in perm gen space ? The perm gen is not a problem her (JDK 8 does not have it and we see OOME on J

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2014-01-21 Thread David Holmes
Hi Peter, On 22/01/2014 12:00 AM, Peter Levart wrote: Hi, David, Kalyan, Summing up the discussion, I propose the following patch for ReferenceHandler: http://cr.openjdk.java.net/~plevart/jdk9-dev/OOMEInReferenceHandler/webrev.01/ I can live with it, though it maybe that once Cleaner has bee