Streams and Spliterator characteristics confusion

Hi, I'm trying to understand how the Spliterator.characteristics are maintained across stream operations and I'm a bit confused. Maybe someone here can clear it up for me s.sorted().spliterator() - Spliterator.SORTED = true But if I use specify a comparator the stream is not sorted

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

On Jun 26, 2014, at 6:53 PM, Claes Redestad claes.redes...@oracle.com wrote: On 06/25/2014 06:43 PM, Paul Sandoz wrote: On Jun 19, 2014, at 7:39 PM, Claes Redestad claes.redes...@oracle.com wrote: Hi, an updated webrev with reworked, public methods is available here:

Re: Streams and Spliterator characteristics confusion

On Jun 27, 2014, at 9:06 AM, Kasper Nielsen kaspe...@gmail.com wrote: Hi, I'm trying to understand how the Spliterator.characteristics are maintained across stream operations and I'm a bit confused. Maybe someone here can clear it up for me Internally in the stream pipeline we keep track

Re: RFR: 8048207 : (xs) Collections.checkedQueue offer() calls add() on wrapped queue

On Jun 27, 2014, at 1:58 AM, Mike Duigou mike.dui...@oracle.com wrote: Hello all; This changeset corrects an issue with the Collections.checkedQueue() utility method added in Java 8. The wrapper implementation incorrectly calls add() on the wrapped queue rather than offer(). I

Re: Long valueOf instead of new Long

I created an issue to track the progress and also made 2 webrevs. One for the original patch and one for the changes that have been suggested earlier in this thread by Paul and Andrej. Here we go: https://bugs.openjdk.java.net/browse/JDK-8048267

Re: Long valueOf instead of new Long

Hi Pavel, the both web revs looks identical to me. Here is what I have found so far in the webrev.01: in src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java: @@ -108,11 +108,11 @@ * @param primaryGroup true if the specified GID represents the *

Re: Long valueOf instead of new Long

Hi Andrej, They are not identical. Maybe it's just hard to spot it as it's not an incremental webrev. Have a look at (line 583): http://cr.openjdk.java.net/~prappo/8048267/webrev.00/src/share/classes/javax/management/modelmbean/RequiredModelMBean.java.sdiff.html

Re: Long valueOf instead of new Long

I've just created a webrev with all the changes we've discussed so far. Plus some more I've spotted while looking into the code. Please note, this webrev is not incremental. It grabs all the changes between the original patch and the latest discussed:

Re: RFR : 7095856: OutputStreamHook doesn't handle null values

looks fine Sean On Jun 27, 2014, at 8:35 AM, Seán Coffey sean.cof...@oracle.com wrote: Looking for a review around this CORBA issue. bug report : https://bugs.openjdk.java.net/browse/JDK-7095856 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7095856/ Null values cause issue when

Re: RFR [9] 8041972: Add improved parse/format methods for Long/Integer

Hi, updated webrev:http://cr.openjdk.java.net/~redestad/8041972/webrev.11 Changes: - Remove use of IllegalArgumentException in favor of IndexOutOfBoundsException/NumberFormatException, making the new methods behave in line with how String.substring wouldat some edge cases:

Re: Long valueOf instead of new Long

Hi Pavel, I'm not sure what the style guide for the source code says, but there is a space between the cast operator and the field name in src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServer.java (line 881): @Override public Long getSnmpOutGenErrs() { -return new

RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

Hi, Please review a webrev for fixing rawtypes and unchecked lint warning for macosx specific java code, this webrev is depending on JDK-8043548[1] where some of the override methods are defined, Also as the src/macosx/classes/apple/launcher/JavaAppLauncher.java to be removed from

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

Hi Henry, Your changes look good to me (I assume there was an issue using wildcards in AquaComboBoxButton.java). Thanks, -Joe On 06/27/2014 02:45 PM, Henry Jen wrote: Hi, Please review a webrev for fixing rawtypes and unchecked lint warning for macosx specific java code, this webrev is

Re: Long valueOf instead of new Long

I found more two unnecessary valueOf. About Andrej, is it not possible add two people in Contributed-by: tag? diff -r d02b062bc827 src/share/classes/com/sun/tools/example/debug/tty/Commands.java --- a/src/share/classes/com/sun/tools/example/debug/tty/Commands.java Fri Jun 13 11:21:30 2014 -0700

Re: RFR: 8044862: Fix raw and unchecked lint warnings in macosx specific code

  On June 27, 2014 at 3:00:13 PM, Joe Darcy (joe.da...@oracle.com(mailto:joe.da...@oracle.com)) wrote: Hi Henry, Your changes look good to me (I assume there was an issue using wildcards in AquaComboBoxButton.java). Cannot make it to work. The problematic code is in line 169,  169