Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

2016-09-19 Thread Igor Ignatyev
Dmitry, Thank you for review. — Igor > On Sep 19, 2016, at 1:40 PM, Dmitry Samersoff > wrote: > > Igor, > > Looks good for me. > > -Dmitry > > On 2016-09-19 12:17, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ >>> 62 lines

Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

2016-09-19 Thread Igor Ignatyev
Staffan, Thank you for review! — Igor > On Sep 19, 2016, at 12:25 PM, Staffan Larsen > wrote: > > Looks good! > > Thanks, > /Staffan > >> On 19 sep. 2016, at 11:17, Igor Ignatyev wrote: >> >>

Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

2016-09-19 Thread Dmitry Samersoff
Igor, Looks good for me. -Dmitry On 2016-09-19 12:17, Igor Ignatyev wrote: > http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ >> 62 lines changed: 56 ins; 2 del; 4 mod; > > Hi all, > > could you please review this small patch which removes usage of jtreg > internal API from

RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Joe Wang
Hi, Please review an addition of StAX tests to the Catalog Support test set. JBS: https://bugs.openjdk.java.net/browse/JDK-8166220 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8166220/webrev/ Thanks, Joe

RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Brent Christian
Hi, Please review my fix for 8165372 : "StackWalker performance regression following JDK-8147039" Bug: https://bugs.openjdk.java.net/browse/JDK-8165372 Webrev: http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/ 8147039 reimplemented stack walking using javaVFrames in place of

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Joe Wang
Thanks Lance! Best Joe On 9/19/16, 1:13 PM, Lance Andersen wrote: Hi Joe, Seems OK. Best Lance On Sep 19, 2016, at 3:11 PM, Joe Wang > wrote: Hi, Please review an addition of StAX tests to the Catalog Support test set. JBS:

RE: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-19 Thread Langer, Christoph
Hi all, thanks for your valuable input. So, since libjli.so can't use libjvm.so and its dladdr() port, there's no way around the libjli.so specific version of it. However, in libjli.so it is only used for resolving pathnames of the program, so the code can be very lean. Hence I completely

RFR(S) : 8166262 : failurehandler should not use jtreg internal API

2016-09-19 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ > 62 lines changed: 56 ins; 2 del; 4 mod; Hi all, could you please review this small patch which removes usage of jtreg internal API from failurehandler lib? JBS: https://bugs.openjdk.java.net/browse/JDK-8166262 webrev:

RE: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-19 Thread Lindenmaier, Goetz
Hi Christoph, This looks good now. Please adapt the copyright year in java_md.h. I would appreciate this getting pushed to get our builds going again. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Montag, 19. September 2016 10:45 > To: Volker Simonis

Re: RFR: 8166220: Catalog API: JAXP XML Processor Support - add StAX test coverage

2016-09-19 Thread Lance Andersen
Hi Joe, Seems OK. Best Lance > On Sep 19, 2016, at 3:11 PM, Joe Wang wrote: > > Hi, > > Please review an addition of StAX tests to the Catalog Support test set. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8166220 > webrev:

Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Mandy Chung
> On Sep 19, 2016, at 12:35 PM, Brent Christian > wrote: > > Hi, > > Please review my fix for 8165372 : "StackWalker performance regression > following JDK-8147039" > > Bug: https://bugs.openjdk.java.net/browse/JDK-8165372 > Webrev:

Re: RFR(S) : 8166262 : failurehandler should not use jtreg internal API

2016-09-19 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 19 sep. 2016, at 11:17, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8166262/webrev.00/ >> 62 lines changed: 56 ins; 2 del; 4 mod; > > Hi all, > > could you please review this small patch which removes usage of

Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Brent Christian
Thanks for the good suggestions. Webrev updated in place: http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/ -Brent

Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Mandy Chung
+1 Mandy > On Sep 19, 2016, at 3:57 PM, Brent Christian > wrote: > > Thanks for the good suggestions. Webrev updated in place: > http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/ > > -Brent >