RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms

2017-02-16 Thread Frank Yuan
Hi Max and All Would you like to review http://cr.openjdk.java.net/~fyuan/8175043/webrev.00/? Bug: https://bugs.openjdk.java.net/browse/JDK-8175043 Some JAXP tests are impacted by JDK-8168410, to fix the issue, I added the pull path name to the file name in the tests, and added a temporar

Re: RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms

2017-02-16 Thread Weijun Wang
Hi Frank You got the idea here correctly, that is to say, the path used in permission granting must match the style of how you access the file. The fix should work. On the other hand, the code change touches too many files. You'll need someone in the JAXP field to confirm if this is the best

RE: RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms

2017-02-16 Thread Frank Yuan
> -Original Message- > From: Weijun Wang [mailto:weijun.w...@oracle.com] > Subject: Re: RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing > across platforms > > Hi Frank > > You got the idea here correctly, that is to say, the path used in > permission granting must match the

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-16 Thread Daniel Fuchs
Hi Aleksej, On 15/02/17 23:49, Aleks Efimov wrote: Hi, The new webrev with addressed comments was uploaded here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01 This is probably a question for the upstream project, but I'm puzzled by this change: http://cr.openjdk.java.net/

RE: RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms

2017-02-16 Thread Frank Yuan
Since no one has more comment, and Joe agree this solution, I will push the change. Thanks Frank > -Original Message- > From: Weijun Wang [mailto:weijun.w...@oracle.com] > Sent: Thursday, February 16, 2017 4:35 PM > To: Frank Yuan; 'Daniel Fuchs'; core-libs-dev@openjdk.java.net > Subject

rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Langer, Christoph
Hi Daniel, when starting "rmid" from current builds on Linux (and probably other Unix platforms as well) we are currently getting the exception below. It looks as if on that path libnio was not loaded and hence we're getting an UnsatisfiedLinkError. In UnixNativeDispatcher.java one can find a s

Re: RFR: 8174735 Update JAX-WS RI integration to latest version

2017-02-16 Thread Roman Grigoriadi
Hi Daniel, On 02/16/2017 11:39 AM, Daniel Fuchs wrote: Hi Aleksej, On 15/02/17 23:49, Aleks Efimov wrote: Hi, The new webrev with addressed comments was uploaded here: http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01 This is probably a question for the upstream project, bu

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Daniel Fuchs
Hi Christoph, It looks like one of the dreaded class initialization cycle issues. If you look at the stack trace, you will see that UnixNativeDispatcher.:609 calls System.loadLibrary at line 611 which later down the road calls the native UnixNativeDispatcher.getcwd command from sun.nio.fs.UnixFi

RE: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Langer, Christoph
Hi Daniel, thanks for your hints - I should probably have seen that myself if I would have had a more thorough look... I'm cc-ing nio-dev, maybe somebody has an idea. I probably won't be able to analyze this short term. Best regards Christoph > -Original Message- > From: Daniel Fuchs

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Daniel Fuchs
On 16/02/17 15:22, Langer, Christoph wrote: Hi Daniel, thanks for your hints - I should probably have seen that myself if I would have had a more thorough look... I'm cc-ing nio-dev, maybe somebody has an idea. I probably won't be able to analyze this short term. No problem. Do you know whe

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Alan Bateman
On 16/02/2017 14:52, Daniel Fuchs wrote: : I don't think this has anything to do with JDK-8173607. JDK-8173607 just splitted the JMX RMI Connector out of java.management - and rmid has nothing to do with JMX. rmid doesn't depend on either java.management or java.management.rmi, and I don't see

RE: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Langer, Christoph
The colleagues tell me that it was about two weeks ago. But I guess it's rather a felt experience than a concrete date ;-) > -Original Message- > From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Donnerstag, 16. Februar 2017 17:02 > To: Langer, Christoph ; nio- > d...@openjdk.ja

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Claes Redestad
Yes, verified that reverting to eager initialization of the system image reader avoids this issue. I guess we need to back this optimization out and see if we can improve things in the future: diff -r 32cb9898b630 src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java --- a/src/

RE: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Baesken, Matthias
It started showing up ~ 5 / 6 th February (talking about openjdk 9 dev ). Regards, Matthias > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 16. Februar 2017 17:04 > To: Daniel Fuchs ; nio-...@openjdk.java.net > Cc: Zeller, Arno ; Baesken, Matthias > ; core-libs-de

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Alan Bateman
Make sense for now, you can also change System.initPhase3 is not trigger eager initialization. I guess the rmid tests must be disabled as otherwise this would have been noticed, it's the odd man because it sets the security manager in its main method rather than on the command line. -Alan On

Re: rmid on Unix fails with Exception - maybe aftermath of JDK-8173607 ??

2017-02-16 Thread Claes Redestad
Done, filed https://bugs.openjdk.java.net/browse/JDK-8175079 and pushed a fix which also cleans up the hack in System.initPhase3. /Claes On 02/16/2017 05:17 PM, Alan Bateman wrote: Make sense for now, you can also change System.initPhase3 is not trigger eager initialization. I guess the rmid t

Re: RFR [JAXP] [TESTBUG] JDK-8175043 Multiple jaxp tests failing across platforms

2017-02-16 Thread huizhe wang
+1. Yes, specific permission is desirable. Thanks for the quick fix! -Joe On 2/16/2017 5:36 AM, Frank Yuan wrote: Since no one has more comment, and Joe agree this solution, I will push the change. Thanks Frank -Original Message- From: Weijun Wang [mailto:weijun.w...@oracle.com] Se

RFR JDK-8174996: jar leaves temporary file when exception occur in creating jar

2017-02-16 Thread Xueming Shen
Hi, Please help review the change for issue: https://bugs.openjdk.java.net/browse/JDK-8174996 webrev: http://cr.openjdk.java.net/~sherman/8174996/webrev The cause/trigger of this "regression" is that the jdk9 jar implementation now builds the target jar file on a temporary file first and then

Re: JDK 9 RFR of JDK-8175062: Mark java/nio/channels/AsyncCloseAndInterrupt.java as intermittently failing

2017-02-16 Thread Brian Burkhalter
[Re-directing to nio-dev] Looks OK. Thanks, Brian On Feb 15, 2017, at 11:10 PM, Amy Lu wrote: > java/nio/channels/AsyncCloseAndInterrupt.java > > This test is known to fail intermittently (JDK-8172045), this patch is to > mark the test accordingly with keyword 'intermittent'. > > Please re

Re: RFR JDK-8174996: jar leaves temporary file when exception occur in creating jar

2017-02-16 Thread Paul Sandoz
Hi Sherman, Can you use File.deleteOnExit instead of explicitly deleting? Paul. > On 16 Feb 2017, at 12:09, Xueming Shen wrote: > > Hi, > > Please help review the change for > > issue: https://bugs.openjdk.java.net/browse/JDK-8174996 > webrev: http://cr.openjdk.java.net/~sherman/8174996/webr

JDK 10 RFR of JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode

2017-02-16 Thread Joseph D. Darcy
Hello, Please review the patch below to address JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode Thanks, -Joe diff -r e405d4bf5c56 src/java.base/share/classes/java/lang/System.java --- a/src/java.base/share/classes/java/lang/System.javaTue Feb 14 16:56:12 2

Re: JDK 10 RFR of JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode

2017-02-16 Thread Lance Andersen
Looks fine Joe -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Feb 16, 2017, at 9:29 PM, Joseph D. Darcy wrote: > > Hello, > > Please review the patch be

Re: JDK 10 RFR of JDK-8172928: Add doc link from System.identityHashCode to Object.hashCode

2017-02-16 Thread Martin Buchholz
Ever since @link became available, it's been preferable to find some way to use @link instead of @see. Why not @linkify the existing reference to Object.hashCode somehow? Less obvious is how to do that for Objects.hashCode - this may indeed be a good use for @see. On Thu, Feb 16, 2017 at 6:29 PM