Re: [1] RFR(XXS): 8197927: Can't set mandatory 'java.vendor.version' property to empty string

On Fri, Feb 16, 2018 at 8:17 PM, wrote: > 2018/2/16 10:59:57 -0800, volker.simo...@gmail.com: > > On Fri, Feb 16, 2018 at 7:02 PM, mark.reinh...@oracle.com wrote: > >> Of course it's possible. The specification need merely say that > >> `java.vendor.version` is a

Re: FileOutputStream.available() and pipe EOF

>> or instead of relying on an undocumented behaviour Fine. Isn't the goal of Java to behave equally on various OSes? If there's a difference, we should adopt the best variant AND document it. And in this case it is to throw an exception on EOF. I don't know about Solaris, but on Windows it's a

Re: [PATCH] RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

Hi Paul, > Hi Adam, > > From reading the thread i cannot tell if this is part of a wider solution including some yet to be proposed HotSpot changes. The wider solution would need to include some Hotspot changes, yes. I'm proposing raising a bug, committing the code we have here to "set the

Re: RFR: 8194154: JDK crashes parsing path string contains '//' on linux

On 19/02/2018 05:09, yumin qi wrote: Thanks! I need a sponsor for pushing it to jdk. Can you or someone else help to push it? minqi is a jdk committer. If this is you then you should be able to push it yourself. -Alan.

Re: [JDK-6341887] Patch: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

On Sat, Feb 17, 2018 at 3:18 PM, Xueming Shen wrote: > Hi David, > > Thanks for taking this one :-) some comments here. Thanks for the review! > (1) I would assume you might have to do more for ByteBuffer, something like > [...] > btw, any reason go unsafe to get

Re: RFR: 8197594 - String and character repeat

. On Sun, Feb 18, 2018 at 11:19 AM, Martin Buchholz wrote: > > - how many digits to consume after the escape? How much do we trust > Unicode to never ever grow beyond 5 hex digits? > Oops, I already got it wrong - it's already at 6 hex digits because there are 17

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

As requested, here are the results with modifications to the annotations on Reference.reachabilityFence. Much more promising ... * Benchmark 1 * Test Code : package org.sample; import org.openjdk.jmh.annotations.Benchmark; import org.openjdk.jmh.annotations.Level; import

8196830: publicLookup().findVirtual should not return method handle to AccessibleObject.setAccessible

AccessibleObject's setAccessible(boolean) is currently not caller sensitive but the overrides in Method/Field/Constructor are. This awkwardness stems from its constructor being protected and the method not being final. It is thus possible to extend the class outside of the java.lang.reflect

Re: RFR: 8194154: JDK crashes parsing path string contains '//' on linux

Yes, I am committer. Brian, do you okay with the version? If no objection, I will push it into jdk. Thanks Yumin On Mon, Feb 19, 2018 at 2:28 AM, Alan Bateman wrote: > On 19/02/2018 05:09, yumin qi wrote: > >> Thanks! >> >> I need a sponsor for pushing it to jdk. Can

Re: [JDK-6341887] Patch: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

On Sun, Feb 18, 2018 at 3:33 AM, Alan Bateman wrote: > Thanks for bringing this one up again Thanks for taking the time to review. > I see Sherman is looking at implementation so I'll stick with the javadoc > for now. At some point it will need a security review to