RE: RFR: 8184693: (opt) add Optional.isEmpty

Hi All, Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/ Regards Vivek -Original Message- From: Vivek Theeyarath Sent: Saturday, April 14, 2018 6:24 PM To: Remi Forax Cc: core-libs-dev Subject: RE:

Re: RFR: 8184693: (opt) add Optional.isEmpty

Hi Vivek, Looks good to me, nitpicking, when creating the list with List.of() in the tests, a space after each comma is missing var list = List.of(2, 3, 4); cheers, Rémi - Mail original - > De: "Vivek Theeyarath" > À: "Remi Forax" ,

Re: RFR: 8184693: (opt) add Optional.isEmpty

> On 15 Apr 2018, at 11:25, Vivek Theeyarath > wrote: > > Hi All, >Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/ This looks ok to me. For consistency, can you please update the copyright header year range in OptionalInt. -Chris.