Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

Hi Matthias, java_props_md.c: 564. Please move the buildNumber check inside the "case 0:" above. Then it won't need the extra check for minorVersion == 0. Thanks, Roger On 10/18/2018 10:30 AM, Baesken, Matthias wrote: Hello, please review my updated webrev :

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

Hello, please review my updated webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8211106.1/ - check changed to build number of recentlyreleased Windows Server 2019 GA version (17763) - adjusted comments a bit ( see also https://en.wikipedia.org/wiki/Windows_Server_2019

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

It sounds like this is still not the last one but I’m ok with your check since the real GA will be higher and we’re real close. "On October 6, 2018, distribution of Windows version 1809 (build 17763[18] ) was paused while

JDK-8198620: New Convenient-Methods for java.util.stream.Stream

Hi, A while back I commented on the suggestion to deal with an annoyance of casting in a stream [1]. I brought an argument that was used in project Amber for a similar case. Like Tagir Valeev, I also see the filter-then-map pattern in various projects I work on. I would like to know if this

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

Thank you, Roger Chris > On 19 Oct 2018, at 2:54 AM, Roger Riggs wrote: > > +1, > > On 09/20/2018 04:55 AM, vyom tewari wrote: >> Hi Chris, >> >> tests looks good to me. >> >> Thanks, >> >> >> >> On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote: >>> Please review the changes to

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Thank you, Roger Chris > On 19 Oct 2018, at 2:56 AM, Roger Riggs wrote: > > Hi Chris, > > Looks ok. > > Roger > > > On 08/20/2018 03:24 AM, vyom tewari wrote: >> Hi Chris, >> >> Latest webrev(.02) looks good to me. One minor comment i will suggest you to >> expand "setContext" as you

Re: RFR: JDK-8210031: implementation for JVM Constants API

On 10/15/18 11:12 AM, Vicente Romero wrote: [1] http://cr.openjdk.java.net/~vromero/8210031/webrev.01 I reviewed java.lang.invoke change in details.  I have skimmed through the new classes. I will look at the new tests next. @since 12 is missing in the new APIs VarHandle.java 1887

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Thank you, Roger Chris > On 19 Oct 2018, at 2:51 AM, Roger Riggs wrote: > > Hi Chris, > > Sorry, for the delay. I'd lost track of this review. > > Looks fine. > > Roger > > > On 08/20/2018 05:28 AM, Chris Yin wrote: >> Hi, Roger >> >> Sorry for the late response since I was on vacation

Re: JDK-8198620: New Convenient-Methods for java.util.stream.Stream

I still don't think this one clears the bar. On 10/18/2018 2:44 PM, Nir Lisker wrote: Hi, A while back I commented on the suggestion to deal with an annoyance of casting in a stream [1]. I brought an argument that was used in project Amber for a similar case. Like Tagir Valeev, I also see the

6850720: Allow POSIX_SPAWN to be used for ProcessImpl on Linux

The issue 6850720 isn't _exactly_ to use POSIX_SPAWN for process launching on Linux, but it's the closest I could find out of what are really a surprisingly large number of issues that refer to posix_spawn in one way or another relating to ProcessImpl. There's a different issue to move from vfork

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

Hi Chris, Looks ok. Roger On 08/20/2018 03:24 AM, vyom tewari wrote: Hi Chris, Latest webrev(.02) looks good to me. One minor comment i will suggest you to  expand "setContext" as you did for other JNDI tests. Thanks, Vyom On Friday 10 August 2018 02:34 PM, Chris Yin wrote: Sorry...

Re: [12] RFR 8200151: Add 8 JNDI tests to com/sun/jndi/dns/ConfigTests/

Hi Chris, Sorry, for the delay. I'd lost track of this review. Looks fine. Roger On 08/20/2018 05:28 AM, Chris Yin wrote: Hi, Roger Sorry for the late response since I was on vacation and thank you for the comments, inline and update webrev as below

Re: RFR: JDK-8210031: implementation for JVM Constants API

Hi all, Please review also the CSR at [1]. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8202031 On 10/15/18 2:12 PM, Vicente Romero wrote: Hi all, sorry for the repeated number of mails on this issue. I have added a direct link to the patch the right link to the webrev is

Re: [12] RFR 8210339: Add 10 JNDI tests to com/sun/jndi/dns/FedTests/

+1, On 09/20/2018 04:55 AM, vyom tewari wrote: Hi Chris, tests  looks good to me. Thanks, On Tuesday 04 September 2018 12:00 PM, Chris Yin wrote: Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/FedTests/ in OpenJDK, thanks bug:

Re: Is it possible to find PDB (windows debugging info) for publishedjvm.dll?

Hm. In my experience, if you attempt to debug the VM at the level Alexander intended, you usually do not get very far without rebuilding, if only to get a fastdebug or slowdebug build. And if you have the knowledge to debug the VM, building it should be not a big hurdle. Just my 5c.. (Should you

Approval Request to update TreeSet#add method documentation

Hi Team, Please provide your approval to update TreeSet#add method as it's documentation and behavior are not consistent. For more information, please refer my mail below and attachment. Thanks & Regards, *Kishor Golapelliwar,* The ability to convert ideas to things is the secret to outward

Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner

Andrew, I can sponsor your change > On Oct 17, 2018, at 5:18 PM, Lance Andersen wrote: > > +1 >> On Oct 17, 2018, at 4:50 PM, Andrew Luo > > wrote: >> >> Done as well, thanks for spotting that also. >> >> diff --git