Re: RFR: 8211917: (zipfs) Creating or updating a JAR file system should put the MANIFEST.MF at the start

I realized that the verify() method in the testcase can include a couple of more tests while dealing with the JarInputStream. So I've updated that method and created a fresh webrev which is available at https://cr.openjdk.java.net/~jpai/webrev/8211917/3/webrev/ -Jaikiran On 11/02/20 10:03 pm,

Re: [PATCH] Enhancement proposal for java.util.StringJoiner

Hello again, I've reworked the patch according to your recommendation: no SharedSercrets and StringBUilder instead. The patch attached. The results are below: Benchmark (count) (latin) (length) Original Patched1 SBUnits

Re: JEP 370 - text example leads to exception

Thanks Paul! Maurizio On 10/02/2020 17:58, Paul Sandoz wrote: I modified the JEP with updated code snippets that compile against the latest API in JDK 14 [*].

Re: JEP 370 - text example leads to exception

Thanks Chris, both for catching the mistake and for testing out the feature - as you can imagine we'd like to collect as much feedback as possible to make sure the API gets finalized right. Cheers Maurizio On 11/02/2020 02:12, Chris T wrote: Paul, thank you very much! In the meantime I

RE: tools/jpackage/linux - tests (from 8212780: Packaging Tool Implementation)

Btw. rpmbuild 4.8 (default on RedHat 6) shows the same issue : rpmbuild --version RPM version 4.8.0 rpmbuild --eval=%{_target_cpu} x86_64 rpmbuild: no spec files given for build So I think a check for rpmbuild > (maybe >= ?) 4.10 would make sense , otherwise a lot of the

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

Here is the webrev for Phillip’s proposed change for the splash image http://cr.openjdk.java.net/~lancea/6202130/splash/ > On Feb 10, 2020, at 4:22 PM, Lance Andersen wrote: > > Hi all, > > Here is a webrev for the patch that Philipp is

RE: tools/jpackage/linux - tests (from 8212780: Packaging Tool Implementation)

Hi Alexey, with rpmbuild 4.4 on SLES11 we get the additional output "rpmbuild: no spec files given for build" when calling rpmbuild --eval=%{_target_cpu} , This seems to mess up the test e.g. jdk/test/jdk/tools/jpackage/linux/AppCategoryTest.java: rpmbuild

Re: [15] RFR (xs) 8046362 IdentityHashMap.hash comments should be clarified

Hi Stuart, The implNote compares the performance impact without mentioning that HashMap uses 'equals()' vs '==' which might have as big an impact on performance as sequential vs chained references. Detailed performance comparisons are very difficult given the factors that impact performance,

Re: [15] RFR (xs) 8046362 IdentityHashMap.hash comments should be clarified

On Mon, Feb 10, 2020 at 4:09 PM Stuart Marks wrote: > > Should I proceed with pushing my comments changes (which I've appended > below for > convenience)? > You already have my approval!

Re: RFR: 8211917: (zipfs) Creating or updating a JAR file system should put the MANIFEST.MF at the start

Hello Lance, On 05/02/20 3:13 am, Lance Andersen wrote: > Hi Jaikiran, > > Thank you again for tackling this feature request. > > Overall, I think this looks OK. > > In ZipFileSystem.java, I would reverse the if statement given a > MANiFEST.MF present is going to be the exception vs the norm.  

Re: tools/jpackage/linux - tests (from 8212780: Packaging Tool Implementation)

Hi Matthias, I confirm jpackage works with rpmbuild v4.11.3. - Alexey On 2/11/2020 4:15 AM, Baesken, Matthias wrote: Hi Alexey, with rpmbuild 4.4 on SLES11 we get the additional output "rpmbuild: no spec files given for build" when calling rpmbuild --eval=%{_target_cpu} , This

Re: [15] RFR: 8234347: "Turkey" meta time zone does not generate composed localized names, 8236548: Localized time zone name inconsistency between English and other locales

Hi, I modified the proposed changeset. Removed the hard coded 3-letter id compatibility mappings (oldMappings) from CLDRConverter.java. Instead, using public ZoneId.SHORT_IDS that contain the same set of mappings (wasn't aware it was defined in the spec!) Here is the updated webrev:

Re: [15] RFR (xs) 8046362 IdentityHashMap.hash comments should be clarified

Hi Roger, I don't want to have a detailed discussion of the performance tradeoffs in the comments. My comments changes are intended to address two specific points: the "multiply by -127" phrase and the arrangement of alternating keys and values in the array. Both have been sources of

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi Mandy, Bob, Thanks again for the reviews and patience on this. Sorry it took me so long to get back to this :-/ Updated webrev: Full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/webrev/ incremental:

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hi Ivan, Will this have enough of a compatibility concern to warrant a CSR? It will change the behavor of these cases. In the RegExTest, the failures should print which case is failing. (Line 4961, 4990). Regards, Roger On 2/7/20 3:05 PM, Ivan Gerasimov wrote: Gentle ping. I had to

Re: RFR 8214245 : (regex) Case insensitive matching doesn't work correctly for some character classes

Hello, Yes, I believe this change should have a CSR, and most likely a release note. Thanks, -Joe On 2/11/2020 12:49 PM, Roger Riggs wrote: Hi Ivan, Will this have enough of a compatibility concern to warrant a CSR? It will change the behavor of these cases. In the RegExTest, the

Re: [15] RFR: 8234347: "Turkey" meta time zone does not generate composed localized names, 8236548: Localized time zone name inconsistency between English and other locales

+1. That's nicer. -Joe On 2/11/20 10:17 AM, naoto.s...@oracle.com wrote: Hi, I modified the proposed changeset. Removed the hard coded 3-letter id compatibility mappings (oldMappings) from CLDRConverter.java. Instead, using public ZoneId.SHORT_IDS that contain the same set of mappings

Re: 6202130: Need to handle UTF-8 values and break up lines longer than 72 bytes

Hi, Can the code in Manifest.java be simplified using regex? E.g., var gc = Pattern.compile("\\X"); gc.matcher(line).results() .map(MatchResult::group) .forEach( // print till 72 bytes in UTF-8 ); Just a thought. If BreakIterator is preferred, it should take Locale.US as

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

I there are no objections I'll push the fix to JDK/client. On 12/11/19 7:29 pm, Igor Ignatyev wrote: Hi Sergey, overall looks good to me. a question about linux, is there an alternative to gnome-screenshot for DEs other than GNOME? -- Igor On Dec 11, 2019, at 1:00 AM, Sergey Bylokhov

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

I applied your patch to the latest JDK 15 sources and ran the container tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some issues. I’m not sure if its my setup or not. I also ran the same build on Ubuntu with docker/cgroupv1. I didn't see any failures on the cgroupv1