> On 24 Jun 2021, at 22:27, Mandy Chung wrote:
>
> On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
> wrote:
>
>> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
>> against JDK17.
>>
>> This fixes the deadlock in ClassLoader between the two lock objects - a lock
On Thu, 24 Jun 2021 18:42:23 GMT, Mandy Chung wrote:
> `Lookup::accessClass` should determine the accessibility of the element type.
> An array class is accessible if and only if its element type is accessible.
>
> This also fixes a spec bug to document `@throws NullPointerException` if the
On Thu, 24 Jun 2021 21:06:54 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger
Hi all,
Could you please review the 8269373 bug fixes?
These tests call java.lang.ProcessBuilder in direct, so not used jtreg command
option. To run non-localized tests, -Duser.language=en and -Duser.country=US
options should be added in ProcessBuilder.
-
Commit messages:
-
Hi, can I have a review of this change that adds two new utility methods for
java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of
ByteOrder.nativeOrder() is to check if the underlying platform is
little-endian/big-endian. There is no reason to only provide
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev
wrote:
> Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
> convert" and "hdiutil detach". Workaround in same way by repeating "create"
> command. Modified RetryExecutor to pass write to file flag, otherwise
>
Prefer using ByteOrder to compute byte order for StringUTF16 to determining
byte order by native method StringUTF16.isBigEndian.
-
Commit messages:
- replace
Changes: https://git.openjdk.java.net/jdk/pull/4596/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4596=00
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
>
On Fri, 18 Jun 2021 09:50:49 GMT, Aleksei Voitylov
wrote:
> Resubmitting the following PR https://github.com/openjdk/jdk/pull/3976
> against JDK17.
>
> This fixes the deadlock in ClassLoader between the two lock objects - a lock
> object associated with the class being loaded, and the
>
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote:
> Hi, can I have a review of this change that adds two new utility methods for
> java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of
> ByteOrder.nativeOrder() is to check if the underlying platform is
>
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been integrated.
Changeset: 1d167978
On Fri, 25 Jun 2021 13:40:54 GMT, Yi Yang wrote:
> Prefer using ByteOrder to compute byte order for StringUTF16 to determining
> byte order by native method StringUTF16.isBigEndian.
Adding new dependencies in `String` quite probably risks bootstrapping issues.
There is a reason why `String`
On 25/06/2021 14:51, David Lloyd wrote:
Is this better than the current solution of `nativeOrder() ==
BIG_ENDIAN` other than reducing a few keystrokes?
I wouldn't expect many developers would need to be concerned with the
platform endianness, it's more likely going to be something advanced,
On Wed, 23 Jun 2021 11:58:06 GMT, Jan Lahoda wrote:
>> Currently, an enum switch with patterns is desugared in a very non-standard,
>> and potentially slow, way. It would be better to use the standard
>> `typeSwitch` bootstrap to classify the enum constants. The bootstrap needs
>> to accept
Is this better than the current solution of `nativeOrder() ==
BIG_ENDIAN` other than reducing a few keystrokes?
On Fri, Jun 25, 2021 at 8:45 AM Yi Yang wrote:
>
> Hi, can I have a review of this change that adds two new utility methods for
> java.nio.ByteOrder? Looking through the whole JDK
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote:
> Hi, can I have a review of this change that adds two new utility methods for
> java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of
> ByteOrder.nativeOrder() is to check if the underlying platform is
>
> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
> property.
> Fix description in the example of a filter allowing platform classes.
> Suppress some warnings about use of SecurityManager in tests.
Roger Riggs has updated the pull request incrementally with one
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev
On Fri, 25 Jun 2021 13:30:56 GMT, Yi Yang wrote:
> Hi, can I have a review of this change that adds two new utility methods for
> java.nio.ByteOrder? Looking through the whole JDK codebase, most calls of
> ByteOrder.nativeOrder() is to check if the underlying platform is
>
On Fri, 25 Jun 2021 14:54:45 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Fri, 25 Jun 2021 08:44:54 GMT, Chris Hegarty wrote:
>> `Lookup::accessClass` should determine the accessibility of the element
>> type. An array class is accessible if and only if its element type is
>> accessible.
>>
>> This also fixes a spec bug to document `@throws
On Fri, 25 Jun 2021 14:54:45 GMT, Roger Riggs wrote:
>> Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory
>> property.
>> Fix description in the example of a filter allowing platform classes.
>> Suppress some warnings about use of SecurityManager in tests.
>
> Roger
`java.lang.reflect.Proxy::newProxyInstance` and
`java.lang.invoke.MethodHandleProxies::asInterfaceInstance` do not specify how
to deal with sealed interfaces. These APIs should reject sealed interface
with `IllegalArgumentException` which is thrown if the given interface is
invalid.
Please
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Fri, 25 Jun 2021 16:48:45 GMT, Brent Christian wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update logging of faults in jdk.serialFilterFactory to log only the
>> exception message
>> Simplify the
Hi David,
In my humble option, it is reasonable to provide APIs to check whether the
underlying platform is big-endian/little-endian.For most cases, we want a
checking(byte order) rather than retrieving(byte order).
--
From:David
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote:
> Fix a regression caused by the previous BCEL update. The issue was fixed in
> the current BCEL repo with a reversal of the previous code, adding back
> "gos.close();". Note however, doing so will result in a warning: [try]
> explicit call to
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
-
Commit messages:
- 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
Changes:
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Changes look good Max
-
Marked as reviewed by lancea
On Fri, 25 Jun 2021 01:39:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has updated
On Fri, 25 Jun 2021 17:49:37 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 6766844: Add bug ID to test
>
> The spec for ByteArrayInputStream.read(byte[], off, len) is pretty specific
>
On Tue, 22 Jun 2021 20:08:03 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
On Fri, 25 Jun 2021 19:39:22 GMT, Valerie Peng wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move TokenPoller to Runnable
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line
> 952:
On Fri, 25 Jun 2021 20:47:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
This pull request has now been integrated.
Changeset: 223759fb
Author:Naoto Sato
URL:
On Fri, 25 Jun 2021 17:24:58 GMT, Mandy Chung wrote:
> `java.lang.reflect.Proxy::newProxyInstance` and
> `java.lang.invoke.MethodHandleProxies::asInterfaceInstance` do not specify
> how to deal with sealed interfaces. These APIs should reject sealed
> interface with
The wording of the @implSpec referred to internal methods in the description.
The patch rewords the @implSpec to be more descriptive of the algorithm than
the methods used.
-
Commit messages:
- non-infinite to finite
- Use limiting
- Remove use of clamping
- Merge branch
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
one more
On Wed, 23 Jun 2021 00:06:25 GMT, Brian Burkhalter wrote:
> Augment the specification of
> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
> with respect to the `File` parameter `directory`.
This pull request has now been integrated.
Changeset: 68ef21db
Author:
On 6/21/2021 2:02 PM, Paul Sandoz wrote:
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
the whole JDK codebase.
Yi Yang has updated
jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
builds.
Until the root cause of the issue is understood and fixed let's add a
workaround to jpackage tests to run test app few more times if the first
attempt resulted in app crash.
-
Commit messages:
-
On Tue, 22 Jun 2021 20:08:03 GMT, Sean Coffey wrote:
>> Sufficient permissions missing if this code was ever to run with
>> SecurityManager.
>>
>> Cleanest approach appears to be use of InnocuousThread to create the
>> cleaner/poller threads.
>> Test case coverage extended to cover the
On Fri, 25 Jun 2021 22:41:10 GMT, Alexey Semenyuk wrote:
> jpackage app launcher randomly crashes JVM at termination in EMS enabled JDK
> builds.
> Until the root cause of the issue is understood and fixed let's add a
> workaround to jpackage tests to run test app few more times if the first
> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
> `read(byte[],int,int)` to return zero per the `InputStream` specification
> when the byte array actual or specified length is zero.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since
> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
> `read(byte[],int,int)` to return zero per the `InputStream` specification
> when the byte array actual or specified length is zero.
Brian Burkhalter has refreshed the contents of this pull request, and previous
commits have
> `Lookup::accessClass` should determine the accessibility of the element type.
> An array class is accessible if and only if its element type is accessible.
>
> This also fixes a spec bug to document `@throws NullPointerException` if the
> argument is null.
>
> Please review the CSR:
>
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Thu, 24 Jun 2021 20:01:27 GMT, Brian Burkhalter wrote:
> Merge identical Unix and Windows versions of FileOutputStream_md.c into
> single, common FileOutputStream.c.
This pull request has now been integrated.
Changeset: 3fae4b37
Author:Brian Burkhalter
URL:
On Fri, 25 Jun 2021 20:47:21 GMT, Brian Burkhalter wrote:
>> Modify `java.io.ByteArrayInputStream` methods `read(byte[])` and
>> `read(byte[],int,int)` to return zero per the `InputStream` specification
>> when the byte array actual or specified length is zero.
>
> Brian Burkhalter has
On Fri, 25 Jun 2021 20:49:16 GMT, Roger Riggs wrote:
>> Brian Burkhalter has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
>
On Tue, 22 Jun 2021 21:59:43 GMT, Alexander Matveev
wrote:
> Looks like another "Resource busy" issue similar to recent fixes for "hdiutil
> convert" and "hdiutil detach". Workaround in same way by repeating "create"
> command. Modified RetryExecutor to pass write to file flag, otherwise
>
56 matches
Mail list logo
