Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v2]

2022-04-22 Thread Xiaohong Gong
> Currently the vector load with mask when the given index happens out of the > array boundary is implemented with pure java scalar code to avoid the IOOBE > (IndexOutOfBoundaryException). This is necessary for architectures that do > not support the predicate feature. Because the masked load

Re: RFR: 8283667: [vectorapi] Vectorization for masked load with IOOBE with predicate feature [v2]

2022-04-22 Thread Xiaohong Gong
On Wed, 20 Apr 2022 02:46:09 GMT, Xiaohong Gong wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java >> line 2861: >> >>> 2859: ByteSpecies vsp = (ByteSpecies) species; >>> 2860: if (offset >= 0 && offset <= (a.length - >>>

RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
This PR fixes a typo. - Commit messages: - Fix typo Changes: https://git.openjdk.java.net/jdk/pull/6942/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6942=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8285440 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. @bridgekeeper I was waiting for "oca-verify", so I'm a bit confused. Please let me know if there's anything I need to do. - PR: https://git.openjdk.java.net/jdk/pull/6942

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Julian Waters
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. No need to worry, all you need to do is comment to reset the timer. There's nothing much else to do besides creating a JBS issue related to the PR (You do need one for the checks to pass, unfortunately I can't help

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Dalibor Topic
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Hi, please (re)submit a completed OCA at OCA.opensource.oracle.com. - PR: https://git.openjdk.java.net/jdk/pull/6942

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Fri, 22 Apr 2022 07:35:52 GMT, Jaikiran Pai wrote: >> @robilad Hi. Thanks for the feedback! >> >> I submitted it again. I tried to fill it as possible as I can this time. >> Please let me know if there's anything missing. > > Hello @izeye, I've created a JBS issue for this change >

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Johnny Lim
On Thu, 24 Mar 2022 20:28:59 GMT, Dalibor Topic wrote: >> This PR fixes a typo. > > Hi, > > please (re)submit a completed OCA at OCA.opensource.oracle.com. @robilad Hi. Thanks for the feedback! I submitted it again. I tried to fill it as possible as I can this time. Please let me know if

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Jaikiran Pai
On Fri, 25 Mar 2022 00:55:00 GMT, Johnny Lim wrote: >> Hi, >> >> please (re)submit a completed OCA at OCA.opensource.oracle.com. > > @robilad Hi. Thanks for the feedback! > > I submitted it again. I tried to fill it as possible as I can this time. > Please let me know if there's anything

Re: RFR: 8285440: Typo in Collections.addAll method javadoc

2022-04-22 Thread Jaikiran Pai
On Fri, 31 Dec 2021 18:58:43 GMT, Johnny Lim wrote: > This PR fixes a typo. Thank you for contributing. The change looks fine to me. After someone with a Reviewer role approves this change, I can sponsor this for you. - Marked as reviewed by jpai (Committer). PR:

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v2]

2022-04-22 Thread Sibabrata Sahoo
> A new API to support replacing selective lines with desired content. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update FileUtils.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/8360/files -

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v2]

2022-04-22 Thread Daniel Fuchs
On Fri, 22 Apr 2022 12:36:15 GMT, Sibabrata Sahoo wrote: >> A new API to support replacing selective lines with desired content. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update FileUtils.java

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v3]

2022-04-22 Thread Ron Pressler
On Sun, 17 Apr 2022 04:57:34 GMT, Jaikiran Pai wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >>

RFR: 8285452: Support new API to replace a file content using FileUtils.java

2022-04-22 Thread Sibabrata Sahoo
A new API to support replacing selective lines with desired content. - Commit messages: - 8285452: Support new API to replace a file content using FileUtils.java - Revert "8285452: Support new API to replace a file content in FileUtils.java" - 8285452: Support new API to replace a

Re: RFR: 8283620: System.out does not use the encoding/charset specified in the Javadoc

2022-04-22 Thread Alan Bateman
On Fri, 15 Apr 2022 20:26:55 GMT, Naoto Sato wrote: > Promoting the internal system properties for `System.out` and `System.err` so > that users can override the encoding used for those streams to `UTF-8`, > aligning to the `Charset.defaultCharset()`. A CSR has also been drafted.

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double [v2]

2022-04-22 Thread Raffaello Giulietti
> Add useful constants specified in IEEE 754. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double - Changes: - all:

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v3]

2022-04-22 Thread Sibabrata Sahoo
On Fri, 22 Apr 2022 14:30:57 GMT, Sibabrata Sahoo wrote: >> A new API to support replacing selective lines with desired content. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update FileUtils.java API doc added along

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v3]

2022-04-22 Thread Sibabrata Sahoo
> A new API to support replacing selective lines with desired content. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: Update FileUtils.java - Changes: - all: https://git.openjdk.java.net/jdk/pull/8360/files -

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v3]

2022-04-22 Thread Daniel Fuchs
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote: >> A new API to support replacing selective lines with desired content. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > Update FileUtils.java

RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double

2022-04-22 Thread Raffaello Giulietti
Add useful constants specified in IEEE 754. - Commit messages: - 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double Changes: https://git.openjdk.java.net/jdk/pull/8362/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8362=00 Issue:

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double

2022-04-22 Thread Raffaello Giulietti
On Fri, 22 Apr 2022 14:26:07 GMT, Raffaello Giulietti wrote: > Add useful constants specified in IEEE 754. The precision of float resp. double values, as defined by IEEE 754, is not easily derivable from the constants in the java.lang.Float resp. java.lang.Double classes. These values (24

RFR: 8285485: Fix typos in corelibs

2022-04-22 Thread Magnus Ihse Bursie
I ran `codespell` on modules owned by core-libs, and accepted those changes where it indeed discovered real typos. I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder). The long term goal here

Re: RFR: 8283620: System.out does not use the encoding/charset specified in the Javadoc [v2]

2022-04-22 Thread Naoto Sato
On Fri, 22 Apr 2022 09:31:19 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified the spec for the new system properties. > > src/java.base/share/classes/java/lang/System.java line 780: > >>

Re: RFR: 8284642: Unexpected behavior of -XX:MaxDirectMemorySize=0

2022-04-22 Thread Harold Seigel
On Wed, 13 Apr 2022 12:24:46 GMT, Harold Seigel wrote: > Please review this small fix for JDK-8284642. The fix was tested by running > Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux > x64. Additionally, the modified test and the test in the bug report were run >

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double [v2]

2022-04-22 Thread Joe Darcy
On Fri, 22 Apr 2022 14:38:06 GMT, Raffaello Giulietti wrote: >> Add useful constants specified in IEEE 754. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8285477: Add a PRECISION public static field to j.l.Float

Re: RFR: 8285452: Support new API to replace a file content using FileUtils.java [v3]

2022-04-22 Thread Weijun Wang
On Fri, 22 Apr 2022 16:06:22 GMT, Daniel Fuchs wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update FileUtils.java > > test/lib/jdk/test/lib/util/FileUtils.java line 402: > >> 400: if

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double [v2]

2022-04-22 Thread Raffaello Giulietti
On Fri, 22 Apr 2022 16:34:46 GMT, Joe Darcy wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double > >

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double [v3]

2022-04-22 Thread Raffaello Giulietti
> Add useful constants specified in IEEE 754. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double - Changes: - all:

Re: RFR: 8283620: System.out does not use the encoding/charset specified in the Javadoc [v2]

2022-04-22 Thread Naoto Sato
> Promoting the internal system properties for `System.out` and `System.err` so > that users can override the encoding used for those streams to `UTF-8`, > aligning to the `Charset.defaultCharset()`. A CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one

Re: RFR: 8284642: Unexpected behavior of -XX:MaxDirectMemorySize=0 [v2]

2022-04-22 Thread Harold Seigel
> Please review this small fix for JDK-8284642. The fix was tested by running > Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux > x64. Additionally, the modified test and the test in the bug report were run > locally. > > Thanks, Harold Harold Seigel has updated

Re: RFR: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double [v3]

2022-04-22 Thread Joe Darcy
On Fri, 22 Apr 2022 17:36:26 GMT, Raffaello Giulietti wrote: >> Add useful constants specified in IEEE 754. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8285477: Add a PRECISION public static field to j.l.Float

Re: RFR: 8285366: Fix typos in serviceability

2022-04-22 Thread Serguei Spitsyn
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on modules owned by the serviceability team > (`java.instrument java.management.rmi java.management jdk.attach > jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi > jdk.jdwp.agent jdk.jstatd

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner

2022-04-22 Thread Brent Christian
On Wed, 20 Apr 2022 13:48:21 GMT, Daniel Fuchs wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to a

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v2]

2022-04-22 Thread Brent Christian
> Please review this change to replace the finalizer in > `AbstractLdapNamingEnumeration` with a Cleaner. > > The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult > res`, and `LdapClient enumClnt`) are moved to a static inner class . From > there, the change is fairly

RFR: 8285445: cannot open file "NUL:"

2022-04-22 Thread Brian Burkhalter
Change the default value of the `jdk.io.File.enableADS` property to `true`. - Commit messages: - 8285445: cannot open file "NUL:" Changes: https://git.openjdk.java.net/jdk/pull/8373/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8373=00 Issue:

Re: RFR: 8285445: cannot open file "NUL:"

2022-04-22 Thread Mikael Vidstedt
On Sat, 23 Apr 2022 01:11:56 GMT, Brian Burkhalter wrote: > Change the default value of the `jdk.io.File.enableADS` property to `true`. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8373

Re: RFR: 8285445: cannot open file "NUL:"

2022-04-22 Thread Bernd Eckenfels
Is that really a needed fix? enabling ADS and less strict parsing might introduce vulnerability but on the other hand NUL: should be allowed for it is a drive style not a ADS. I would also think the number of users who want use NUL: is smaller than the number of users who benefit from ADS

Re: RFR: 8284642: Unexpected behavior of -XX:MaxDirectMemorySize=0 [v2]

2022-04-22 Thread David Holmes
On Fri, 22 Apr 2022 18:14:27 GMT, Harold Seigel wrote: >> Please review this small fix for JDK-8284642. The fix was tested by running >> Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux >> x64. Additionally, the modified test and the test in the bug report were >>

Re: RFR: 8283620: System.out does not use the encoding/charset specified in the Javadoc [v2]

2022-04-22 Thread David Holmes
On Fri, 22 Apr 2022 18:10:27 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/lang/System.java line 780: >> >>> 778: * The property may be set on the command line to the value >>> 779: * {@code UTF-8}. Setting the property to a value other than >>> {@code UTF-8} >>>

Re: RFR: 8283620: System.out does not use the encoding/charset specified in the Javadoc [v2]

2022-04-22 Thread David Holmes
On Fri, 22 Apr 2022 18:14:18 GMT, Naoto Sato wrote: >> Promoting the internal system properties for `System.out` and `System.err` >> so that users can override the encoding used for those streams to `UTF-8`, >> aligning to the `Charset.defaultCharset()`. A CSR has also been drafted. > > Naoto