Re: Why does we still need StrictMath?

2022-05-08 Thread Andrew Haley
On 5/8/22 06:54, Victor Williams Stafusa da Silva wrote: If StrictMath is still needed and could produce different results than Math in some modern hardware, then by the javadocs, it seems to imply that Math should always delegate to StrictMath and never the other way around. Why is it not

Why does we still need StrictMath?

2022-05-08 Thread Victor Williams Stafusa da Silva
JEP 306 was already delivered some time ago. And with it, we get rid of the need of that nasty strictfp and the need to have both loose FP and strict FP. However, the class java.lang.StrictMath is still around as a normal class, almost mirroring java.lang.Math, and I really can't understand why.

RFR: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

2022-05-08 Thread Leonid Mesnik
…resulting in failure to produce a stack when a test times out - Commit messages: - 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out Changes: https://git.openjdk.java.net/jdk/pull/8588/files Webrev:

Re: RFR: 8285517: System.getenv() returns unexpected value if environment variable has non ASCII character [v6]

2022-05-08 Thread Ichiroh Takiguchi
On Sat, 7 May 2022 06:50:40 GMT, Ichiroh Takiguchi wrote: >> On JDK19 with Linux ja_JP.eucjp locale, >> System.getenv() returns unexpected value if environment variable has >> Japanese EUC characters. >> It seems this issue happens because of JEP 400. >> Arguments for ProcessBuilder have same

Re: RFR: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out

2022-05-08 Thread David Holmes
On Sun, 8 May 2022 21:57:20 GMT, Leonid Mesnik wrote: > …resulting in failure to produce a stack when a test times out Looks good. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8588

Re: RFR: 8286298: Remove unused methods in sun.invoke.util.VerifyType

2022-05-08 Thread Alan Bateman
On Fri, 6 May 2022 11:32:25 GMT, Claes Redestad wrote: > A few untested and unused methods in `VerifyType` which can be removed. > (Possibly used by native JSR 292 implementations in JDK 7). Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8570

Re: RFR: 8286163: micro-optimize Instant.plusSeconds

2022-05-08 Thread Claes Redestad
On Wed, 4 May 2022 20:27:04 GMT, lennartfricke wrote: > Provide micro-benchmark for comparison Marked as reviewed by redestad (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8542

Re: RFR: 8286163: micro-optimize Instant.plusSeconds

2022-05-08 Thread Claes Redestad
On Fri, 6 May 2022 22:02:58 GMT, Stephen Colebourne wrote: > Seems reasonable to me. plus(long, long) already has this optimisation. If it already had this optimization then why change anything? I think you're referring to the check for `0` to return `this` then that is something

Re: RFR: JDK-8286347: incorrect use of `{@link}`

2022-05-08 Thread Jonathan Gibbons
On Sat, 7 May 2022 01:27:57 GMT, Joe Darcy wrote: > Looks fine in and of itself, but not sure how it will interact with the > (presumed) integration of JEP 424: "Foreign Function & Memory API (Preview)" > which will at least move the file, if not otherwise modify it. I assume the changes are

Re: Why does we still need StrictMath?

2022-05-08 Thread Martin Desruisseaux
Le 08/05/2022 à 10:56, Andrew Haley a écrit : Some targets (x86, in particular) have intrinsics (log, trig) that are faster than StrictMath and also more accurate. StrictMath is not about accuracy, but cross-architecture down-to-the-last bit reproducibility. Whether we still need that

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-08 Thread Doug Lea
On Sun, 8 May 2022 01:51:17 GMT, Martin Buchholz wrote: >> Doug Lea has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Accommodate restrictive SecurityManagers >> - merge with loom updates >>Merge remote-tracking branch

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v5]

2022-05-08 Thread Doug Lea
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Test improvements - Changes: - all:

Re: Why does we still need StrictMath?

2022-05-08 Thread Victor Williams Stafusa da Silva
Sure, there are the x86 intrinsics. But since JEP 306 was delivered, is this still valid? The Motivation section of the JEP 306 seems to imply that this is not the case anymore. Of course, I could just be grossly misunderstanding what is/was JEP 306 and/or to which depth it meant by "restore

Re: Why does we still need StrictMath?

2022-05-08 Thread Victor Williams Stafusa da Silva
Was that using Java 17+, which included JEP 306 delivered? Em dom., 8 de mai. de 2022 às 08:10, Martin Desruisseaux < martin.desruisse...@geomatys.com> escreveu: > Le 08/05/2022 à 10:56, Andrew Haley a écrit : > > > Some targets (x86, in particular) have intrinsics (log, trig) that are > >

Re: Why does we still need StrictMath?

2022-05-08 Thread Martin Desruisseaux
Le 08/05/2022 à 14:15, Victor Williams Stafusa da Silva a écrit : Was that using Java 17+, which included JEP 306 delivered? No, but my understanding is that JEP 306 does not apply to Math versus StrictMath behavior. In my understanding, the strictfp keyword was only about the use of