On Thu, 9 Jun 2022 21:11:55 GMT, David M. Lloyd wrote:
>> https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178
>>
>> Instead of separate Hashtable.get/remove calls we can just use value
>> returned by
This fixes a bug introduced with JDK-8202449.
-
Commit messages:
- 8288173: JDK-8202449 fix causes conformance test failure
Changes: https://git.openjdk.org/jdk/pull/9120/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9120=00
Issue:
> https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178
>
> Instead of separate Hashtable.get/remove calls we can just use value returned
> by `remove`,
> It results in cleaner and a bit faster code.
> The test
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java`
> verifies different failure modes of resource bundles. One of the failures is
> that the runner class, `MissingResourceCauseTestRun.java`, creates a file
> `UnreadableRB`, and runs `chmod 000` on it, to
On Tue, 7 Jun 2022 12:19:29 GMT, Magnus Ihse Bursie wrote:
> The test
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTest.java`
> verifies different failure modes of resource bundles. One of the failures is
> that the runner class, `MissingResourceCauseTestRun.java`,
On Fri, 10 Jun 2022 08:26:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses
>> https://bugs.openjdk.java.net/browse/JDK-8285405?
>>
>> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the
>> existing
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote:
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to
When trying to construct an LdapURL object with a bad input string (in this
example the _ in ad_jbs is causing issues), and not using
the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
into the exception below :
import com.sun.jndi.ldap.LdapURL;
String url =
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for
> various APIs of this
On Sat, 28 May 2022 12:00:00 GMT, Andrey Turbanov wrote:
> Hashtable doesn't allow `null` values. So, instead of pair
> `containsKey`/`remove` calls, we can directly call `remove` and then compare
> result with `null`.
>
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing
> `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for
> various APIs of this
On Fri, 10 Jun 2022 06:45:00 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/jdk/internal/misc/Signal.java line 180:
>>
>>> 178: if (newH == 2) {
>>> 179: handlers.put(sig, handler);
>>> 180: }
>>
>> If you made this change instead:
>>
>>
On Fri, 10 Jun 2022 10:49:25 GMT, Martin Doerr wrote:
> LGTM and sounds feasible.
Hi Martin, thanks for the review.
-
PR: https://git.openjdk.org/jdk/pull/9105
On Fri, 10 Jun 2022 13:15:11 GMT, Alan Bateman wrote:
> We have to be cautious about leaking security sensitive configuration in
> exception messages. Can you look at the security property
> jdk.includeInException (conf/security/java.security) and usages in the JDK
> for ideas on how this
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote:
> Expired Flags in 20:
>
> - FilterSpuriousWakeups
> - MinInliningThreshold
> - PrefetchFieldsAhead
>
> No remaining usages in code or tests.
>
> - UseHeavyMonitors (expired in PRODUCT ONLY)
>
> As this flag now only exists for debug
On Fri, 10 Jun 2022 13:41:48 GMT, Matthias Baesken wrote:
> Hi Alan , sure we could use something like the already existing hostInfo of
> property jdk.includeInException private static final boolean
> enhancedExceptionText = SecurityProperties.includedInExceptions("hostInfo");
> and make the
Expired Flags in 20:
- FilterSpuriousWakeups
- MinInliningThreshold
- PrefetchFieldsAhead
No remaining usages in code or tests.
- UseHeavyMonitors (expired in PRODUCT ONLY)
As this flag now only exists for debug builds it has to be a "develop" flag
rather than product. There are then changes
There are many instanceof checks in the sun.reflection.annotation code; these
would be improved by using pattern matching for instanceof.
-
Commit messages:
- JDK-8288227: Refactor annotation implementation to use pattern matching for
instanceo
Changes:
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Fix copyright year
-
Changes:
- all:
On Fri, 10 Jun 2022 16:30:57 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9120
On Wed, 8 Jun 2022 04:59:07 GMT, Yoshiki Sato wrote:
> Please review this PR.
> SDK 10.15 and earlier reports os.version as 10.16 on Big Sur. This fix will
> check if dynamic linker support, which is supported from Big Sur, is
> available or not on the OS even if os.version is reported as
On Fri, 10 Jun 2022 16:15:36 GMT, Joe Darcy wrote:
> There are many instanceof checks in the sun.reflection.annotation code; these
> would be improved by using pattern matching for instanceof.
This pull request has now been integrated.
Changeset: aaa89714
Author:Joe Darcy
URL:
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the
On Fri, 10 Jun 2022 11:31:06 GMT, Andrey Turbanov wrote:
>> https://github.com/openjdk/jdk/blob/bc28baeba9360991e9b7575e1fbe178d873ccfc1/src/java.base/share/classes/jdk/internal/misc/Signal.java#L177-L178
>>
>> Instead of separate Hashtable.get/remove calls we can just use value
>> returned by
On Fri, 10 Jun 2022 16:15:36 GMT, Joe Darcy wrote:
> There are many instanceof checks in the sun.reflection.annotation code; these
> would be improved by using pattern matching for instanceof.
Seems clean
-
PR: https://git.openjdk.org/jdk/pull/9129
On Fri, 10 Jun 2022 16:15:36 GMT, Joe Darcy wrote:
> There are many instanceof checks in the sun.reflection.annotation code; these
> would be improved by using pattern matching for instanceof.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9129
On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
The fix reverts an inadvertent "correction" sneaked into JDK-8202449, restoring
previous (correct) behavior.
-
PR: https://git.openjdk.org/jdk/pull/9120
On Fri, 10 Jun 2022 18:01:24 GMT, Alan Bateman wrote:
>> Thiago Henrique Hüpner has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix copyright year
>
> test/jdk/tools/jar/modularJar/Basic.java line 44:
>
>> 42:
>> 43: import
On Fri, 10 Jun 2022 18:19:42 GMT, Thiago Henrique Hüpner
wrote:
>> test/jdk/tools/jar/modularJar/Basic.java line 44:
>>
>>> 42:
>>> 43: import jdk.internal.module.ModuleReferenceImpl;
>>> 44: import jdk.internal.module.ModuleResolution;
>>
>> At some point we need to put in test
On Fri, 10 Jun 2022 18:25:09 GMT, Thiago Henrique Hüpner
wrote:
>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved
> flags is used
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Rename dataprovider
-
Changes:
- all:
As the name suggests, `COMPAT` locale provider keeps compatibility with JDK8's
locale data (before CLDR). This is useful for legacy applications, but some of
its data got obsolete for later locale data updates, such as the country name
change for `Eswatini` (formerly known as `Swaziland`).
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote:
> Expired Flags in 20:
>
> - FilterSpuriousWakeups
> - MinInliningThreshold
> - PrefetchFieldsAhead
>
> No remaining usages in code or tests.
>
> - UseHeavyMonitors (expired in PRODUCT ONLY)
>
> As this flag now only exists for debug
8288173: JDK-8202449 fix causes conformance test failure :
api/java_util/Random/RandomGenerator/NextFloat.html
-
Commit messages:
- Backport da2339cf6971532593e4f1b5ebbce8d1ed2e83b2
Changes: https://git.openjdk.org/jdk19/pull/5/files
Webrev:
On Sat, 11 Jun 2022 00:35:52 GMT, Joe Darcy wrote:
> 8288173: JDK-8202449 fix causes conformance test failure :
> api/java_util/Random/RandomGenerator/NextFloat.html
This pull request has now been integrated.
Changeset: f4b05a11
Author:Joe Darcy
URL:
On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
Changes look okay, but please do a follow-up fix to add some regression tests
for this condition.
-
Marked as reviewed by darcy (Reviewer).
PR:
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote:
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote:
> We still handle at a number of places ancient historic _MSC_VER versions of
> Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800).
> This should be cleaned up, as long as it is not 3rd party code that we don't
> want to
On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
This pull request has now been integrated.
Changeset: da2339cf
Author:Raffaello Giulietti
Committer: Brian Burkhalter
URL:
On Sat, 11 Jun 2022 05:48:14 GMT, Alan Bateman wrote:
>> Expired Flags in 20:
>>
>> - FilterSpuriousWakeups
>> - MinInliningThreshold
>> - PrefetchFieldsAhead
>>
>> No remaining usages in code or tests.
>>
>> - UseHeavyMonitors (expired in PRODUCT ONLY)
>>
>> As this flag now only exists
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote:
> Expired Flags in 20:
>
> - FilterSpuriousWakeups
> - MinInliningThreshold
> - PrefetchFieldsAhead
>
> No remaining usages in code or tests.
>
> - UseHeavyMonitors (expired in PRODUCT ONLY)
>
> As this flag now only exists for debug
On Fri, 10 Jun 2022 15:57:40 GMT, Vladimir Kozlov wrote:
>> Expired Flags in 20:
>>
>> - FilterSpuriousWakeups
>> - MinInliningThreshold
>> - PrefetchFieldsAhead
>>
>> No remaining usages in code or tests.
>>
>> - UseHeavyMonitors (expired in PRODUCT ONLY)
>>
>> As this flag now only exists
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote:
> Expired Flags in 20:
>
> - FilterSpuriousWakeups
> - MinInliningThreshold
> - PrefetchFieldsAhead
>
> No remaining usages in code or tests.
>
> - UseHeavyMonitors (expired in PRODUCT ONLY)
>
> As this flag now only exists for debug
46 matches
Mail list logo