Re: Advice on cross-repo change: JDK-8160997

2016-07-08 Thread Alan Burlison
time group. I don't know this well enough, so I'm going to point you to Dan (and Jerry, except Jerry's not a committer). OK, thanks. To run JPRT don't forget to use -testset hotspot and you'll get zero failures. It also touches files under jdk/src, will the hotspot testset suffice? -- Alan Burlison --

RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-08-31 Thread Alan Burlison
vfork(2) is deprecated on Solaris and using it generates compiler warnings. When compiled with warnings-as-errors, this results in compilation failures. Bug:https://bugs.openjdk.java.net/browse/JDK-8161360 Webrev: http://cr.openjdk.java.net/~alanbur/JDK-8161360 Thanks, -- Alan Burlison --

Re: RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-09-01 Thread Alan Burlison
|at Runtime.exec (Runtime.java:635) |at Runtime.exec (Runtime.java:459) |at Runtime.exec (Runtime.java:356) | at (#2:1) jshell> -- Alan Burlison --

Re: RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-09-01 Thread Alan Burlison
On 01/09/2016 14:31, Dmitry Samersoff wrote: Changes looks good for me. Thanks. Could someone possibly sponsor this for me? I don't have commit rights yet... -- Alan Burlison --

RFR: JDK-8165161 Solaris: /usr/ccs /opt/sfw and /opt/csw are dead, references should be expunged

2016-09-01 Thread Alan Burlison
/JDK-8165161 Webrev: http://cr.openjdk.java.net/~alanbur/JDK-8165161/ JPRT hotspot tests all pass. Thanks, -- Alan Burlison --

Re: RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-09-06 Thread Alan Burlison
On 01/09/2016 14:34, Alan Burlison wrote: Changes looks good for me. Thanks. Could someone possibly sponsor this for me? I don't have commit rights yet... Ping... -- Alan Burlison --

Re: RFR: JDK-8165161 Solaris: /usr/ccs /opt/sfw and /opt/csw are dead, references should be expunged

2016-09-06 Thread Alan Burlison
On 01/09/2016 18:43, Alan Burlison wrote: I posted this originally on build-dev, it was suggested I should also post it to core-libs-dev for review of some of the changes. /usr/ccs /opt/sfw and /opt/csw are all obsolete and should be removed from the Solaris-related build infrastructure. Bug

Re: RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-09-06 Thread Alan Burlison
On 06/09/2016 18:10, Roger Riggs wrote: ok, I will sponsor it. Thanks. (Usually the patches are relative to the repo being modified). I can regen it if you want, I've been doing a lot of cross-repo patches and have got into the habit of generating them from the topmost repo ;-) --

Re: RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

2016-09-06 Thread Alan Burlison
d getting them pushed into the J9 repo. -- Alan Burlison --

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Alan Burlison
t see what the problem is, to be honest. -- Alan Burlison --

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Alan Burlison
nd on. Volker was instead proposing what you describe. Ah right, in which case we are in violent agreement ;-) -- Alan Burlison --

Re: Proposal for adding O_DIRECT support into JDK 9

2016-10-13 Thread Alan Burlison
t; - Linus -- Adding support for O_DIRECT has a far wider impact than adding just another IO handle flag. As such I'm opposed to this change as it seems to be prone to cause hard-to-diagnose failures on Linux and it is also specific to just Linux. -- Alan Burlison --

Re: Proposal for adding O_DIRECT support into JDK 9

2016-10-14 Thread Alan Burlison
ache Spark, their over-reliance on platform-specific functionality and native code has made it extremely difficult to get them to work well on platforms other than Linux/x86. We should not make the same mistake in Java itself. -- Alan Burlison --

Re: Proposal for adding O_DIRECT support into JDK 9

2016-11-05 Thread Alan Burlison
On 04/11/2016 18:32, David M. Lloyd wrote: I still feel like it could be a problem to have just one simple getPageSize method, given how many CPU architectures and OSes support multiple page sizes. Yes. $ pagesize -a 8192 65536 4194304 268435456 2147483648 -- Alan Burlison --