Re: RFR: 8263480: ProblemList two jpackage tests on Windows

2021-03-11 Thread Alexander Zvegintsev
On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263552: Use String.valueOf() for char-to-String conversion in ObjectStreamClass

2021-03-15 Thread Alexander Zvegintsev
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов wrote: > This is a very simple and trivial improvement about getting rid of pointless > char wrapping into array Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2660

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules

2021-08-24 Thread Alexander Zvegintsev
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. There are a bunch of calls to `Collections.sort()` without a comparator specified (at least in java.desktop):

Re: RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules [v2]

2021-08-25 Thread Alexander Zvegintsev
On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov wrote: >> src/java.base/share/classes/java/net/URLPermission.java line 222: >> >>> 220: >>> 221: List l = normalizeMethods(methods); >>> 222: l.sort(null); >> >> I am not opposed to this change, but I find this is slightly

Re: Integrated: 8281476: ProblemList tools/jar/CreateMissingParentDirectories.java

2022-02-08 Thread Alexander Zvegintsev
On Tue, 8 Feb 2022 20:09:30 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList tools/jar/CreateMissingParentDirectories.java. Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7390

Re: RFR: 8279918: Fix various doc typos [v2]

2022-01-14 Thread Alexander Zvegintsev
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote: >> - Most of the typos are of a trivial kind: missing whitespace. >> - If any of the typos should be fixed in the upstream projects instead, >> please say so; I will drop those typos from the patch. >> - As I understand it, ` ` in