Collections.synchronized* Javadoc could use see-also links

2019-11-11 Thread Chris Hennick
-> ConcurrentHashMap - synchronizedSet -> ConcurrentHashMap.newKeySet() - synchronizedSortedMap & synchronizedNavigableMap -> ConcurrentSkipListMap - synchronizedNavigableSet & synchronizedSortedSet -> ConcurrentSkipListSet Sincerely, Chris Hennick

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
On Wed, 1 Jun 2022 22:49:01 GMT, Chris Hennick wrote: >> @Pr0methean As @turbanoff observes, I think there's a closing parentheses >> too much on L.1411 and one on L.1421. >> Which compiler are you using ;-) ? > > Should be fixed as of fa340fb47b1169805f21fb71cce0da3

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
of reaching the maximum with an ideal PRNG from > about `1.3877787807814488E-17` to about `1.4323726067488646E-20` (calculated > using the identity `ln(x) == Math.log10(x)/Math.log10(Math.exp(1))`). Chris Hennick has refreshed the contents of this pull request, and previous commits have

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
On Mon, 23 May 2022 14:21:55 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line >> 1411: >> >>> 1409: long U2 = (rng.nextLong() >>> 1); >>> 1410: // Compute the actual x-coordinate of the randomly

Re: RFR: 8284493: Fix rounding error in computeNextExponential; use Math.fma(); use bounded version in computeNextGaussian [v2]

2022-06-01 Thread Chris Hennick
On Wed, 1 Jun 2022 22:53:14 GMT, Chris Hennick wrote: >> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a >> rounding error to accumulate at the tail of the distribution (probably >> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v3]

2022-06-05 Thread Chris Hennick
of reaching the maximum with an ideal PRNG from > about `1.3877787807814488E-17` to about `1.4323726067488646E-20` (calculated > using the identity `ln(x) == Math.log10(x)/Math.log10(Math.exp(1))`). Chris Hennick has updated the pull request with a new target base due to a merge or a

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v4]

2022-06-06 Thread Chris Hennick
of reaching the maximum with an ideal PRNG from > about `1.3877787807814488E-17` to about `1.4323726067488646E-20` (calculated > using the identity `ln(x) == Math.log10(x)/Math.log10(Math.exp(1))`). Chris Hennick has updated the pull request with a new target base due to a merge or a

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-10 Thread Chris Hennick
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote: > Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3); this fixes that by &

RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-10 Thread Chris Hennick
Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a rounding error to accumulate at the tail of the distribution (probably starting around 2*exponentialX0 == 0x1.e46eff20739afp3); this fixes that by tracking the multiple of exponentialX0 as a long. (This changes the maximum