RFR(XS): JDK-8077866: [TESTBUG] Some of java.lang tests cannot be run on compact profiles 1, 2

Hi All, Please review the very small change in TEST.groups file. Webrev link: http://cr.openjdk.java.net/~skovalev/dkononen/8077866/webrev.00/ Bug id: JDK-8077866 https://bugs.openjdk.java.net/browse/JDK-8077866 Testing: automated Description: The following tests cannot be run on compact

[9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, Could someone please review this very small fix. The class JImageTask (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has references to an info message by 'err.cannot.create.dir' key. Unfortunately the corresponding resource file

Re: [9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Hi, Optimized buffer's capacity checks. WEBREV: http://cr.openjdk.java.net/~dkononenko/8169715/webrev.02 > > Could please someone review the fix for JDK-8169715. > > The problem occurs when jimage tool is attempting to read an empty or > incomplete image. The current implementation

[9] RFR: 8169715: jimage fails with IAE when attempts to inspect an empty file

Hi, Could please someone review the fix for JDK-8169715. The problem occurs when jimage tool is attempting to read an empty or incomplete image. The current implementation works with ByteBuffer and always relies on that there's enough data to inspect the image. This results in IAE inside

Re: [9] RFR 8170113: jimage extract to readonly directory causes MissingResourceException

Hi, > > On 06/02/2017 10:27, Denis Kononenko wrote: > > Hi, > > > > Could someone please review this very small fix. > > > > The class JImageTask > (src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java) has > references to an info message by 'e

[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi, Could someone please review these new tests for jimage utility. There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 WEBREV:

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Looks OK to me. > I can suggest two more cases. A directory and file symlink can be > passed in options where tool requires a file path. > > —Andrey > > > On 8 Nov 2016, at 16:17, Denis Kononenko > <denis.konone...@oracle.com> wrote: > > >

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

ry. Then, of course, unneeded module > dependencies are questionable. > > Shura > > > > On Nov 3, 2016, at 6:29 AM, Denis Kononenko > <denis.konone...@oracle.com> wrote: > > > > Hi, > > > > I've done some rework accordingly to Alan's and Shura's

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

Hi Andrey, No, it isn't. I submitted a new CR: https://bugs.openjdk.java.net/browse/JDK-8167384. Thank you, Denis. > Hi, > > Looks OK. Is it 100% pass rate? > > —Andrey > > On 9 Nov 2016, at 20:36, Denis Kononenko > <denis.konone...@oracle.com> wrote: > &g

[9] RFR: 8170120: Several new jimage testcases should be excluded due to their failures

Hi, Could someone please review this small fix. Recently several failing test cases were delivered into jdk9-dev by my mistake (https://bugs.openjdk.java.net/browse/JDK-8167240). I've just renamed these test cases to temporarily avoid their execution. They should be renamed back when

Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

: > https://bugs.openjdk.java.net/browse/JDK-8167384. > > Thank you, > Denis. > > > Hi, > > > > Looks OK. Is it 100% pass rate? > > > > —Andrey > > > On 9 Nov 2016, at 20:36, Denis Kononenko > > <denis.konone...@oracle.com> wrote: > >

[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options

/8167240/webrev.01/ Thank you, Denis. On 06.10.2016 19:37, Denis Kononenko wrote: Hi, Could someone please review these new tests for jimage utility. There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'. BUGURL: https