RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-18 Thread Evgeny Mandrikov
Hello! Please review patch [1] for JDK-8139820 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. With best regards, Evgeny Mandrikov [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8139820 [3] https

RFR: JDK-8152467: remove uses of anachronistic array declarations for method return type

2019-08-15 Thread Evgeny Mandrikov
Hello! Please review patch [1] for JDK-8152467 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. After this change tier1 tests pass and I don't see other occurrences to replace in output of ag "\)\s*\[\s*\]" src With best regards, Evgeny Mandrikov

Re: RFR: JDK-8139820: URLClassPath.FileLoader constructor redundantly checks protocol

2019-08-19 Thread Evgeny Mandrikov
On Mon, Aug 19, 2019 at 12:17 AM Claes Redestad wrote: > I'd add a comment that protocol is assumed to be "file", URLClassPath.FileLoader class already has a comment "from a file URL that refers to a directory", but anyway added comment for constructor. and perhaps make the constructor