On Wed, 15 Sep 2021 07:40:35 GMT, Ravi Reddy wrote:
> Hi all,
>
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close
> operations on GZip we are not setting the deflator to a finis
Hi all,
Please review this fix for Infinite loop in ZipOutputStream.close().
The main issue here is when ever there is an exception during close operations
on GZip we are not setting the deflator to a finished state which is leading to
an infinite loop when we try writing on the same GZip
On Tue, 12 Oct 2021 15:00:11 GMT, Ravi Reddy wrote:
>> the output stream is only closed if an exception is raised though ?
>
> Yes , we are closing the stream only when exception occurs during write
> operation
Yes, we are closing the stream only when an exception occurs
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
On Tue, 12 Oct 2021 14:35:17 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java line 252:
>>
>>> 250: int len = def.deflate(buf, 0, buf.length);
>>> 251: if (len > 0) {
>>> 252: try {
>>
>> Shouldn't this use try with
On Mon, 11 Oct 2021 13:42:35 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the defl
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
On Fri, 17 Sep 2021 12:45:29 GMT, Alan Bateman wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the deflator to a finished state which
>>
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Change in test case name from GZipLoopTest.jav
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Added ZipException case to handle failure
On Thu, 18 Nov 2021 19:09:18 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the defl
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Change in description of test case
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Added better try/catch/finally bl
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682: Infinite loop in ZipOutputStream.close()
-
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
On Tue, 2 Nov 2021 09:54:38 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the defl
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
hen we try writing on the same GZip instance(
> since we use while(!def.finished()) inside the write operation).
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
8193682 : Infinite loop in ZipOutputStream.close()
-
On Tue, 26 Oct 2021 06:30:39 GMT, Ravi Reddy wrote:
>> Hi all,
>>
>> Please review this fix for Infinite loop in ZipOutputStream.close().
>> The main issue here is when ever there is an exception during close
>> operations on GZip we are not setting the defl
On Wed, 15 Sep 2021 07:40:35 GMT, Ravi Reddy wrote:
> Hi all,
>
> Please review this fix for Infinite loop in ZipOutputStream.close().
> The main issue here is when ever there is an exception during close
> operations on GZip we are not setting the deflator to a finis
This fix is for violation of XML specification on Attribute-Value normalization
for external entities having character "\r".
While normalizing entity with '\r', we should be checking if the entity is
external before changing the position and offset. "isExternal()" check is
missed in the new
On Mon, 7 Mar 2022 17:07:20 GMT, Ravi Reddy wrote:
> This fix is for violation of XML specification on Attribute-Value
> normalization for external entities having character "\r".
>
> While normalizing entity with '\r', we should be checking if the entity is
>
Hi All,
This review request contains fix for infinite loop issue in
DeflaterOutputStream.finish() in an exception scenario.
1. The issue is with 'finished' flag not getting set to correct value when
there is an IOException in
DeflaterOutputStream.finish() which will result in Infinite
test case, renaming test
> case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Modified write(byte []b) to write(byte[] b) to maintain same signature across
t
On Wed, 16 Mar 2022 11:59:44 GMT, Sean Coffey wrote:
>> Ravi Reddy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified write(byte []b) to write(byte[] b) to maintain same signature
>> across the te
On Sun, 13 Mar 2022 14:08:57 GMT, Ravi Reddy wrote:
> Hi All,
>
> This review request contains fix for infinite loop issue in
> DeflaterOutputStream.finish() in an exception scenario.
> 1. The issue is with 'finished' flag not getting set to correct value when
> there
While normalizing entity with '\r' , we should be checking if the entity is
external before changing the position and offset.
-
Commit messages:
- 8281093: JDK 11.0.14 violates Attribute-Value Normalization in the XML
specification 1.0
Changes:
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
> Please also update the @lastmodified to "Feb 2022"
Thanks , I have updated the tag.
-
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Updated @LastModified to Feb 2022
-
C
On Fri, 25 Feb 2022 00:50:49 GMT, Ravi Reddy wrote:
> While normalizing entity with '\r' , we should be checking if the entity is
> external before changing the position and offset.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.n
CloseInflaterDeflaterTest.java is failing intermittently(Observed once in macOS
and Linux), testInflaterOutputStream() is added as an extra test as part of
https://bugs.openjdk.java.net/browse/JDK-8278794. Disabling this test for now
before debugging any timing issues in Inflater.
On Tue, 12 Apr 2022 20:09:31 GMT, Ravi Reddy wrote:
> CloseInflaterDeflaterTest.java is failing intermittently(Observed once in
> macOS and Linux), testInflaterOutputStream() is added as an extra test as
> part of https://bugs.openjdk.java.net/browse/JDK-8278794. Disabling this test
On Wed, 16 Mar 2022 16:34:37 GMT, Ravi Reddy wrote:
>> Hi All,
>>
>> This review request contains fix for infinite loop issue in
>> DeflaterOutputStream.finish() in an exception scenario.
>> 1. The issue is with 'finished' flag not getting set to correct value wh
test case, renaming test
> case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional
commit since the last revision:
Modified the format of comments across the test case and also done clean
37 matches
Mail list logo
