Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-28 Thread Stefan Karlsson
Looks good. StefanK On 2020-04-29 06:41, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 16 lines changed: 0 ins; 0 del; 16 mod; Hi all, could you please review this trivial cleanup in tests? from JBS: ClassFileInstaller is a test utility class which copies cla

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

2021-01-26 Thread Stefan Karlsson
On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

2021-02-09 Thread Stefan Karlsson
On Fri, 5 Feb 2021 16:07:09 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

2021-03-11 Thread Stefan Karlsson
On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

2021-03-11 Thread Stefan Karlsson
On Tue, 9 Mar 2021 17:55:12 GMT, Anton Kozlov wrote: >> src/hotspot/share/runtime/thread.cpp line 2515: >> >>> 2513: void JavaThread::check_special_condition_for_native_trans(JavaThread >>> *thread) { >>> 2514: // Enable WXWrite: called directly from interpreter native wrapper. >>> 2515: MA

RFR: 8264489: Add more logging to LargeCopyWithMark.java

2021-03-31 Thread Stefan Karlsson
Add more logging to the LargeCopyWithMark.java test, to gather more information when this test fails with OOME. The intention is to gather more info for JDK-8239089. I consider this patch trivial, and expect to push it after I've gotten on Review. - Commit messages: - 8264489: A

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java

2021-03-31 Thread Stefan Karlsson
On Wed, 31 Mar 2021 08:39:02 GMT, Kim Barrett wrote: >> Add more logging to the LargeCopyWithMark.java test, to gather more >> information when this test fails with OOME. >> >> The intention is to gather more info for JDK-8239089. >> >> I consider this patch trivial, and expect to push it aft

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

2021-03-31 Thread Stefan Karlsson
> Add more logging to the LargeCopyWithMark.java test, to gather more > information when this test fails with OOME. > > The intention is to gather more info for JDK-8239089. > > I consider this patch trivial, and expect to push it after I've gotten one > Review. S

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

2021-03-31 Thread Stefan Karlsson
On Wed, 31 Mar 2021 09:29:43 GMT, Alan Bateman wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Alan > > test/jdk/java/io/BufferedInputStream/LargeCopyWithMark.java

Integrated: 8264489: Add more logging to LargeCopyWithMark.java

2021-03-31 Thread Stefan Karlsson
On Wed, 31 Mar 2021 06:56:23 GMT, Stefan Karlsson wrote: > Add more logging to the LargeCopyWithMark.java test, to gather more > information when this test fails with OOME. > > The intention is to gather more info for JDK-8239089. > > I consider this patch trivial, and

Re: RFR: 8264489: Add more logging to LargeCopyWithMark.java [v2]

2021-03-31 Thread Stefan Karlsson
On Wed, 31 Mar 2021 15:42:14 GMT, Brian Burkhalter wrote: >> Stefan Karlsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Alan > > Marked as reviewed by bpb (Reviewer). Thanks for review

Re: RFR: 8264805: Remove the experimental Ahead-of-Time Compiler [v4]

2021-04-08 Thread Stefan Karlsson
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote: >> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related >> to Ahead-of-Time Compiler from JDK: >> >> - `jdk.aot` module — the `jaotc` tool >> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution

Re: Integrated: 8277649 [BACKOUT] JDK-8277507 Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures

2021-11-23 Thread Stefan Karlsson
On Tue, 23 Nov 2021 15:08:43 GMT, Daniel D. Daugherty wrote: > This reverts commit 12f08ba4d47cb70a0629b17bc3639ce170309f21. > > The fix for JDK-8277507 is causing 38 failures per Tier2 job set. Marked as reviewed by stefank (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

2022-04-27 Thread Stefan Karlsson
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

RFR: 8072921: -Xincgc should be removed from output

2016-04-19 Thread Stefan Karlsson
Hi all, I hope this is the right list for this RFR. Please review this patch to remove the -Xincgc output from the java launcher. http://cr.openjdk.java.net/~stefank/8072921/webrev.01 https://bugs.openjdk.java.net/browse/JDK-8072921 The output can be seen by running 'java -X': $ ../build/lin

Re: RFR: 8072921: -Xincgc should be removed from output

2016-04-20 Thread Stefan Karlsson
On 2016-04-19 12:45, Alan Bateman wrote: On 19/04/2016 10:58, Stefan Karlsson wrote: I've left the locale specific launcher files untouched. Should I update them as well? Dropping -Xincgc rom the -X output looks okay to me. We usually don't touch the translations as they are

Re: RFR: 8204861 : fix for 8196993 has broken the build on linux

2018-06-12 Thread Stefan Karlsson
Looks good to me. Thanks for fixing this. StefanK On 2018-06-12 14:46, Srinivas Dama wrote: Hi, My earlier fix for https://bugs.openjdk.java.net/browse/JDK-8196993 has broken the build on linux. So I am reverting my fix for now. Bug : https://bugs.openjdk.java.net/browse/JDK-8204861 webrev:

hg: jdk8/tl/jdk: 2 new changesets

2013-02-25 Thread stefan . karlsson
Changeset: c6d77b2b4478 Author:stefank Date: 2013-01-22 13:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6d77b2b4478 8006506: Add test for redefining methods in backtraces to java/lang/instrument tests Reviewed-by: sspitsyn, coleenp + test/java/lang/instrument/Redefine

hg: jdk8/tl/jdk: 2 new changesets

2013-03-22 Thread stefan . karlsson
Changeset: 470232a8e89d Author:stefank Date: 2013-03-22 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/470232a8e89d 8005116: NPG: Rename -permstat option for jmap in jdk8 to -clstats Reviewed-by: jmasa, sla Contributed-by: Erik Helin ! src/share/classes/sun/tools/jmap

hg: jdk8/tl/jdk: 8009427: Re-enable tests that were disable to ease complicated push

2013-03-27 Thread stefan . karlsson
Changeset: caafe6dca35d Author:ehelin Date: 2013-03-21 20:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/caafe6dca35d 8009427: Re-enable tests that were disable to ease complicated push Reviewed-by: sla, mchung, dcubed Contributed-by: Erik Helin ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8014659: NPG: performance counters for compressed klass space

2013-09-24 Thread stefan . karlsson
Changeset: b606775fd1a3 Author:stefank Date: 2013-08-29 11:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b606775fd1a3 8014659: NPG: performance counters for compressed klass space Reviewed-by: jmasa, sla Contributed-by: erik.he...@oracle.com ! src/share/classes/sun/tools

hg: jdk8/tl/jdk: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

2013-10-14 Thread stefan . karlsson
Changeset: f15a0087181e Author:stefank Date: 2013-10-14 14:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2 Reviewed-by: coleenp, sla Contributed-by: stefan.karls...@oracle.com, coleen.phillim...