Re: (XS) java.logging Level.java minor cleanups

2018-08-24 Thread Daniel Fuchs
Hi Bernd, Mandy, Sorry I missed answering your question! On 23/08/2018 21:02, mandy chung wrote: On 8/23/18 2:49 PM, Bernd Eckenfels wrote: Did you had any opinion on the synthetic accessors as well? : BTW: I get a synthetic Accessor warning on l.name/value, is this what  nestmates

Re: (XS) java.logging Level.java minor cleanups

2018-08-23 Thread mandy chung
>; Daniel Fuchs <mailto:daniel.fu...@oracle.com> *Cc: *core-libs-dev@openjdk.java.net <mailto:core-libs-dev@openjdk.java.net> *Betreff: *Re: (XS) java.logging Level.java minor cleanups On 8/23/18 2:49 PM, Bernd Eckenfels wrote: > > Did you had any opinion on t

Re: (XS) java.logging Level.java minor cleanups

2018-08-23 Thread Bernd Eckenfels
An: Bernd Eckenfels; Daniel Fuchs Cc: core-libs-dev@openjdk.java.net Betreff: Re: (XS) java.logging Level.java minor cleanups On 8/23/18 2:49 PM, Bernd Eckenfels wrote: > > Did you had any opinion on the synthetic accessors as well? : >> BTW: I get a synthetic Accessor warning on

Re: (XS) java.logging Level.java minor cleanups

2018-08-23 Thread mandy chung
On 8/23/18 2:49 PM, Bernd Eckenfels wrote: Did you had any opinion on the synthetic accessors as well? : BTW: I get a synthetic Accessor warning on l.name/value, is this what nestmates will resolve – is it worth adjusting the modifiers for>> those fields anyway? What warning message

Re: (XS) java.logging Level.java minor cleanups

2018-08-23 Thread Bernd Eckenfels
An: Bernd Eckenfels; core-libs-dev@openjdk.java.net Betreff: Re: (XS) java.logging Level.java minor cleanups Hi Bernd, Good finding! I agree with the proposed cleanup. I am always a bit uneasy of touching these classes as they have a propensity to come back and bite you from behind when you're

Re: (XS) java.logging Level.java minor cleanups

2018-08-23 Thread Daniel Fuchs
Hi Bernd, Good finding! I agree with the proposed cleanup. I am always a bit uneasy of touching these classes as they have a propensity to come back and bite you from behind when you're not looking ;-) I have applied your patch and sent it to our test system for more confidence and everything

(XS) java.logging Level.java minor cleanups

2018-08-11 Thread Bernd Eckenfels
Hello, while investigating a Memory leak fix from IBM (IJ05380 is in 8.0.5.20 but not in 8u yet) I noticed that the (fixed) code registerWithClassLoader(Level) in the master queries a unused class name (pn) and it can use the method reference instead of Lambda. See patch below. There seems to