Re: [12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters
+1 On 7/12/2018 1:28 PM, Naoto Sato wrote: Looks good to me. Naoto On 7/12/18 1:26 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format pattern contains a sequence of over 256 non-ASCII unicode characters, the length field overflows as it is stored as 8-bit. Fix: The handling of long_length (> 254) for non-ASCII unicode characters is missing in the compilation phase of the format pattern, added that in the fix. Regards, Nishit Jain
Re: [12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters
Looks good to me. Naoto On 7/12/18 1:26 AM, Nishit Jain wrote: Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format pattern contains a sequence of over 256 non-ASCII unicode characters, the length field overflows as it is stored as 8-bit. Fix: The handling of long_length (> 254) for non-ASCII unicode characters is missing in the compilation phase of the format pattern, added that in the fix. Regards, Nishit Jain
[12] RFR: 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters
Hi, Please review the fix for JDK-8193444 Bug: https://bugs.openjdk.java.net/browse/JDK-8193444 Webrev: http://cr.openjdk.java.net/~nishjain/8193444/webrev.02/ Cause: If a format pattern contains a sequence of over 256 non-ASCII unicode characters, the length field overflows as it is stored as 8-bit. Fix: The handling of long_length (> 254) for non-ASCII unicode characters is missing in the compilation phase of the format pattern, added that in the fix. Regards, Nishit Jain
