Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection
On 2016-12-01 18:10, Alan Bateman wrote: On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java.net/browse/JDK-8170602 Webrev: http://cr.openjdk.java.net/~redestad/8170602/webrev.01/ Looks okay but I hope we don't have to do too many of these. Thanks for the review, Alan. Hope so too. We've done a lot to improve java.lang.invoke and lambda bootstrap in 9, but there are cases like this that are still too costly to have on the startup path. A few more improvements to the --generate-jli-classes jlink plugin might change things...? :-) Thanks! /Claes -Alan
Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection
On 01/12/2016 15:33, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java.net/browse/JDK-8170602 Webrev: http://cr.openjdk.java.net/~redestad/8170602/webrev.01/ Looks okay but I hope we don't have to do too many of these. -Alan
Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection
Roger, thanks for reviewing! /Claes On 2016-12-01 17:13, Roger Riggs wrote: Looks fine, very straight-forward. On 12/1/2016 10:33 AM, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java.net/browse/JDK-8170602 Webrev: http://cr.openjdk.java.net/~redestad/8170602/webrev.01/ Thanks! /Claes
Re: RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection
Looks fine, very straight-forward. On 12/1/2016 10:33 AM, Claes Redestad wrote: Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java.net/browse/JDK-8170602 Webrev: http://cr.openjdk.java.net/~redestad/8170602/webrev.01/ Thanks! /Claes
RFR: 8170602: Startup regression due to introduction of lambda in java.io.FilePermissionCollection
Hi, recent changes to FilePermissionCollection to use a lambda in place of an explicit BiFunction cause a quite noticeable startup and footprint regression on small applications due to a bootstrap dependency. Therefore I'd like to revert this particular change. Bug: https://bugs.openjdk.java.net/browse/JDK-8170602 Webrev: http://cr.openjdk.java.net/~redestad/8170602/webrev.01/ Thanks! /Claes
