Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

[Alexey Semenyuk]

On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk  wrote:

> 8250950: Allow per-user and system wide configuration of a jpackaged app

@sashamatveev please resume the review

-

PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app [v2]

[Alexander Matveev]

On Mon, 6 Jun 2022 20:37:11 GMT, Alexey Semenyuk  wrote:

>> 8250950: Allow per-user and system wide configuration of a jpackaged app
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add TKit.createDirectories() method that will delete created nonexistent 
> directories.

Marked as reviewed by almatvee (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app [v2]

[Alexey Semenyuk]

> 8250950: Allow per-user and system wide configuration of a jpackaged app

Alexey Semenyuk has updated the pull request incrementally with one additional 
commit since the last revision:

  Add TKit.createDirectories() method that will delete created nonexistent 
directories.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9025/files
  - new: https://git.openjdk.java.net/jdk/pull/9025/files/af2708b4..1f512ff1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9025&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9025&range=00-01

  Stats: 38 lines in 2 files changed: 32 ins; 1 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9025.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9025/head:pull/9025

PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

[Alexey Semenyuk]

On Sat, 4 Jun 2022 01:45:21 GMT, Alexander Matveev  wrote:

>> 8250950: Allow per-user and system wide configuration of a jpackaged app
>
> test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174:
> 
>> 172: action.accept(cmd);
>> 173: } finally {
>> 174: Files.deleteIfExists(targetCfgFile);
> 
> Should we delete parent directory as well?

Correct. We should delete all directories that got created in the preceding 
`Files.createDirectories()` call. Will fix this.

-

PR: https://git.openjdk.java.net/jdk/pull/9025

Re: RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

[Alexander Matveev]

On Fri, 3 Jun 2022 21:07:47 GMT, Alexey Semenyuk  wrote:

> 8250950: Allow per-user and system wide configuration of a jpackaged app

test/jdk/tools/jpackage/share/PerUserCfgTest.java line 174:

> 172: action.accept(cmd);
> 173: } finally {
> 174: Files.deleteIfExists(targetCfgFile);

Should we delete parent directory as well?

-

PR: https://git.openjdk.java.net/jdk/pull/9025

RFR: 8250950: Allow per-user and system wide configuration of a jpackaged app

[Alexey Semenyuk]

8250950: Allow per-user and system wide configuration of a jpackaged app

-

Commit messages:
 - Trailing white space removed
 - EOLs converted
 - Trailing white space removed
 - 8250950: Allow per-user and system wide configuration of a jpackaged app

Changes: https://git.openjdk.java.net/jdk/pull/9025/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9025&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8250950
  Stats: 568 lines in 14 files changed: 512 ins; 36 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9025.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9025/head:pull/9025

PR: https://git.openjdk.java.net/jdk/pull/9025